Skip to content

[3.10] gh-87497: Document that urllib.request sends headers in camel case (GH-24661) #91517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022
Merged

[3.10] gh-87497: Document that urllib.request sends headers in camel case (GH-24661) #91517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53318a7
gh-87497: Document that urllib.request sends headers in camel case (G…
axel3rd Apr 14, 2022
1ddc7bb
Merge branch '3.10' into backport-325d6f5-3.10
JelleZijlstra Apr 15, 2022
ed2a102
Merge branch '3.10' into backport-325d6f5-3.10
JelleZijlstra Apr 17, 2022
48615e5
Merge branch '3.10' into backport-325d6f5-3.10
JelleZijlstra Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Doc/library/urllib.request.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ The following classes are provided:
(X11; U; Linux i686) Gecko/20071127 Firefox/2.0.0.11"``, while
:mod:`urllib`'s default user agent string is
``"Python-urllib/2.6"`` (on Python 2.6).
All header keys are sent in camel case.

An appropriate ``Content-Type`` header should be included if the *data*
argument is present. If this header has not been provided and *data*
Expand Down
9 changes: 9 additions & 0 deletions Lib/test/test_urllib2_localnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,15 @@ def test_sending_headers(self):
pass
self.assertEqual(handler.headers_received["Range"], "bytes=20-39")

def test_sending_headers_camel(self):
handler = self.start_server()
req = urllib.request.Request("http://localhost:%s/" % handler.port,
headers={"X-SoMe-hEader": "foobar"})
with urllib.request.urlopen(req):
pass
self.assertIn("X-Some-Header", handler.headers_received.keys())
self.assertNotIn("X-SoMe-hEader", handler.headers_received.keys())

def test_basic(self):
handler = self.start_server()
with urllib.request.urlopen("http://localhost:%s" % handler.port) as open_url:
Expand Down