Skip to content

gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. #91522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. #91522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Modules/_bisectmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Converted to C by Dmitry Vasiliev (dima at hlabs.spb.ru).
*/

#define PY_SSIZE_T_CLEAN
#define NEEDS_PY_IDENTIFIER
#include "Python.h"

/*[clinic input]
Expand All @@ -14,8 +13,6 @@ module _bisect

#include "clinic/_bisectmodule.c.h"

_Py_IDENTIFIER(insert);

static inline Py_ssize_t
internal_bisect_right(PyObject *list, PyObject *item, Py_ssize_t lo, Py_ssize_t hi,
PyObject* key)
Expand Down Expand Up @@ -132,7 +129,7 @@ _bisect_insort_right_impl(PyObject *module, PyObject *a, PyObject *x,
return NULL;
}
else {
result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
result = PyObject_CallMethod(a, "insert", "nO", index, x);
if (result == NULL)
return NULL;
Py_DECREF(result);
Expand Down Expand Up @@ -258,7 +255,7 @@ _bisect_insort_left_impl(PyObject *module, PyObject *a, PyObject *x,
if (PyList_Insert(a, index, x) < 0)
return NULL;
} else {
result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
result = PyObject_CallMethod(a, "insert", "nO", index, x);
if (result == NULL)
return NULL;
Py_DECREF(result);
Expand Down