[3.9] bpo-46586: Fix more erroneous doc links to builtins (GH-31429) #92199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-bot
added
skip news
docs
serhiy-storchaka
approved these changes
May 3, 2022
| @@ -734,7 +734,7 @@ The following attribute and methods should only be used by classes derived from | |||
|
|
|||
| This method, if implemented, will be called by the parent | |||
| :class:`OpenerDirector`. It should return a file-like object as described in | |||
| the return value of the :meth:`open` of :class:`OpenerDirector`, or ``None``. | |||
| the return value of the :meth:`~OpenerDirector.open` method of :class:`OpenerDirector`, or ``None``. | |||
There was a problem hiding this comment.
It is not related to this PR, but if some item is mentioned multiple times in one paragrafph, I prefer to keep link only in one of them (usually at the first occurrence). :class:`!OpenerDirector` or ``OpenerDirector``. Too many duplicated links do not make the text more readable.
There was a problem hiding this comment.
Makes sense, will keep it in mind for the future.
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…1429) (python#92199) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Éric <merwok@netwok.org>. (cherry picked from commit cc6ae4f) Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Éric merwok@netwok.org.
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri 46469858+meersuri@users.noreply.github.com