bpo-34710: fix SSL module build #9347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this fails on all SSL versions. This was found while building OpenWrt with Python 3.7.0 on x86 & OpenSSL 1.0.2p. The `dh.h` header is included in several files, but it doesn't seem to be included in the ones that are included in `_ssl.c` (as far as I could tell). Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
|
Changelog v1 -> v2:
|
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2018
Include ``openssl/dh.h`` header file to fix implicit function declaration of ``DH_free()``. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> (cherry picked from commit b3a271f) Co-authored-by: Alexandru Ardelean <ardeleanalex@gmail.com>
|
GH-9351 is a backport of this pull request to the 3.7 branch. |
|
GH-9352 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2018
Include ``openssl/dh.h`` header file to fix implicit function declaration of ``DH_free()``. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> (cherry picked from commit b3a271f) Co-authored-by: Alexandru Ardelean <ardeleanalex@gmail.com>
|
Sorry, @commodo and @tiran, I could not cleanly backport this to |
|
That was fast. @tiran - are you doing the cherry-pick to 2.7 or shall I ? |
tiran
pushed a commit
to tiran/cpython
that referenced
this pull request
Sep 17, 2018
Include ``openssl/dh.h`` header file to fix implicit function declaration of ``DH_free()``. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>. (cherry picked from commit b3a271f) Co-authored-by: Alexandru Ardelean <ardeleanalex@gmail.com>
|
GH-9353 is a backport of this pull request to the 2.7 branch. |
|
@commodo I took care of the backport |
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2018
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2018
|
Cool |
miss-islington
pushed a commit
that referenced
this pull request
Sep 17, 2018
Include ``openssl/dh.h`` header file to fix implicit function declaration of ``DH_free()``. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>. (cherry picked from commit b3a271f) Co-authored-by: Alexandru Ardelean <ardeleanalex@gmail.com> https://bugs.python.org/issue34710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this fails on all SSL versions. This was found while building
OpenWrt with Python 3.7.0 on x86 & OpenSSL 1.0.2p.
The
dh.hheader is included in several files, but it doesn't seem to beincluded in the ones that are included in
_ssl.c(as far as I couldtell).
Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com
https://bugs.python.org/issue34710