Skip to content

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit fd54a45)

Co-authored-by: Steve Dower steve.dower@microsoft.com

(cherry picked from commit fd54a45)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawing my review so I can check build results before this merges

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@zooba zooba merged commit 9804af2 into python:3.7 Sep 19, 2018
@miss-islington miss-islington deleted the backport-fd54a45-3.7 branch September 19, 2018 23:41
@miss-islington
Copy link
Contributor Author

@zooba: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@zooba: Status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants