gh-92336: linecache.getline should not raise exceptions on decoding errors #94410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
changed the title
iritkatriel
added
type-bug
gpshead
reviewed
Jun 29, 2022
gpshead
approved these changes
Jun 30, 2022
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-94434 is a backport of this pull request to the 3.11 branch. |
|
GH-94435 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2022
…ding errors (pythonGH-94410) (cherry picked from commit 21cbdae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2022
…ding errors (pythonGH-94410) (cherry picked from commit 21cbdae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for getline says:
This function will never raise an exception — it will return '' on errorsBut it currently does raise exception for encoding errors. This PR fixes that.