gh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS #94413
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``PY_STDMODULE_CFLAGS`` may contain include directories with system headers. This can break compiling with built-in libmpdec.
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @tiran, I had trouble checking out the |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Jun 29, 2022
…ythonGH-94413) ``PY_STDMODULE_CFLAGS`` may contain include directories with system headers. This can break compiling with built-in libmpdec. (cherry picked from commit 6485c3c) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-94415 is a backport of this pull request to the 3.11 branch. |
tiran
added a commit
that referenced
this pull request
Jun 29, 2022
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 30, 2022
…H-94413) ``PY_STDMODULE_CFLAGS`` may contain include directories with system headers. This can break compiling with built-in libmpdec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PY_STDMODULE_CFLAGSmay contain include directories with systemheaders. This can break compiling with built-in libmpdec.