Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Cover PyModule_GetFilename #98545

Closed
wants to merge 1 commit into from
Closed

gh-94808: Cover PyModule_GetFilename #98545

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 22, 2022 •
edited by bedevere-bot
Loading

Notice: PyModule_GetFilename is deprecated.
However, I don't know what the policy is: do we even care to cover deprecated methods?

I think that covering them is still ok: while it is there, it must work correctly.

@sobolevn sobolevn mentioned this pull request Oct 22, 2022
Open
@sobolevn
Copy link
Member Author

Closing, since we don't cover deprecated API: #94808 (comment)

@sobolevn sobolevn closed this Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @bedevere-bot