Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34996: Add name parameter to multiprocessing.Pool #9906

Closed
wants to merge 5 commits into from
Closed

bpo-34996: Add name parameter to multiprocessing.Pool #9906

wants to merge 5 commits into from

Conversation

RazManorAllegro
Copy link

@RazManorAllegro RazManorAllegro commented Oct 16, 2018 •
edited by bedevere-bot
Loading

Contributed byt Allegro.ai

https://bugs.python.org/issue34996

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@RazManorAllegro RazManorAllegro changed the title Add name parameter to proccess and thread pool p.b.o-34996: Add name parameter to proccess and thread pool Oct 16, 2018
@RazManorAllegro RazManorAllegro changed the title p.b.o-34996: Add name parameter to proccess and thread pool pbo-34996 Add name parameter to proccess and thread pool Oct 16, 2018
@tirkarthi
Copy link
Member

tirkarthi commented Oct 16, 2018 •
edited by bedevere-bot
Loading

Hi @RazManorAllegro ,

Can you please change the title to [bpo-34996](https://bugs.python.org/issue34996): Add name parameter to proccess and thread pool so that the PR is linked to the bug tracker. Also please add some description in the bug tracker about the goal or use case of the issue so that the reviewers have more context. I can also see #9907 raised to 2.7 and it's up to the reviewer to decide whether this needs to be back ported once the PR to master is reviewed and merged.

You can find more information about the process : https://devguide.python.org/

Thanks

@RazManorAllegro RazManorAllegro changed the title pbo-34996 Add name parameter to proccess and thread pool [bpo-34996](https://bugs.python.org/issue34996): Add name parameter to proccess and thread pool Oct 16, 2018
@serhiy-storchaka serhiy-storchaka changed the title [bpo-34996](https://bugs.python.org/issue34996): Add name parameter to proccess and thread pool bpo-34996: Add name parameter to proccess and thread pool Oct 17, 2018
matrixise
matrixise requested changes Oct 17, 2018
View reviewed changes
Misc/NEWS.d/next/Library/2018-10-17-09-09-51.bpo-34996.lzdfsg.rst
@@ -0,0 +1 @@
Add name paramter to process and thread pool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the CLA signed, could you fix the typo?

This was referenced Oct 17, 2018
Closed
Merged
@pitrou pitrou changed the title bpo-34996: Add name parameter to proccess and thread pool bpo-34996: Add name parameter to process and thread pool Oct 21, 2018
@pitrou pitrou changed the title bpo-34996: Add name parameter to process and thread pool bpo-34996: Add name parameter to multiprocessing.Pool Oct 21, 2018
tirkarthi
tirkarthi reviewed Oct 22, 2018
View reviewed changes
Lib/multiprocessing/pool.py Outdated
"""Bring the number of pool processes up to the specified number,
for use after reaping workers which have exited.
"""
for i in range(processes - len(pool)):
w = Process(ctx, target=worker,
name='{}-Worker-{}'.format(name, i),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make patchcheck fails in CI in this line due to alignment. Please run make patchcheck locally that fixes this issue for you so that it's aligned with ctx and args .

@tirkarthi
Copy link
Member

Apologies if there were multiple notifications for my comment I wasn't aware of the GitHub outage and clicked on submit 4-5 times thinking it was a network issue from my end.

@brettcannon
Copy link
Member

Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR.

@RazManorAllegro RazManorAllegro mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@matrixise matrixise matrixise requested changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RazManorAllegro @the-knights-who-say-ni @tirkarthi @brettcannon @matrixise @bedevere-bot