Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that bpo issues can be automatically closed using commit message #502

Open
Mariatta opened this issue Jun 27, 2019 · 2 comments

Comments

@Mariatta
Copy link
Member

commented Jun 27, 2019

According to PEP 595, bpo now has a feature where issues can be automatically closed, if the PR commit message looks like closes bpo-NNNN: ...

This should be documented in devguide and announced to core devs/core-workflow mailing list/discourse.

Some questions: what magic keywords accepted? "closes" "fixes" "close" "fix"?
Is it case sensitive? (I assume not)

Does it also update the "resolution" / "stage"?

@webknjaz

This comment has been minimized.

Copy link

commented Jun 29, 2019

Better follow what GitHub has: https://help.github.com/en/articles/closing-issues-using-keywords
This way people won't have to relearn which words work on which platform

Mariatta referenced this issue in python/peps Jul 9, 2019
PEP 581 Updates (#1114)
- include recent changes to bpo
- clarify the downsides of GitHub
@Mariatta

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Reading bpo's source code, the magic words are matching this regex

VERBS = r'(?:\b(?P<verb>close[sd]?|closing|fix(?:e[sd])?|)\s+)?'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.