Add pre-commit setup to the Lifecycle of a pull request

[nineteendo]

---

📚 Documentation preview 📚: https://cpython-devguide--1306.org.readthedocs.build/

[nineteendo]

@erlend-aasland, does this look good?

https://cpython-devguide--1306.org.readthedocs.build/getting-started/pull-request-lifecycle/#step-by-step-guide

[ezio-melotti]

Thanks for the PR!
I think it would be more appropriate to mention pre-commit in the Setup and Building page, since installing pre-commit is something that only needs to be done once, not for every pull request.

The best place would probably be as a subsection of "Installing Git". The step-by-step guide you edited already links there where it lists the prerequisites.

So I would suggest to:

1. Add an "Installing pre-commit" subsection under "Installing Git", explaining how to install/set up pre-commit.
2. Leave the note in the step-by-step guide about fixing errors reported by pre-commit. The note could also link to the "Installing pre-commit" subsection.

[erlend-aasland]

I added some comments after a quick read-through.

[nineteendo]

Could you check what's going wrong with the build? It doesn't tell me anything useful. Hmm, duplicate target name.

[nineteendo]

Do you think it's now clear enough?

[erlend-aasland]

Looks good; thanks @nineteendo, @hugovk and @ezio-melotti.

[nineteendo]

I moved pre-commit under getting the source code: https://cpython-devguide--1306.org.readthedocs.build/getting-started/setup-building/#install-pre-commit-as-a-git-hook. You need to manually install the hook for every repository.

[hugovk]

Thank you!

[nineteendo]

I think this can be merged now. Am I right?

[erlend-aasland]

Thank you!

[encukou]

This will install software on my machine.
Who vouches for the security of that software?