Skip to content

Conversation

lisroach
Copy link

Except for the collapsible sidebar, which requires a change in Sphinx iteself.

Also changed hover color for header links.

Except for the collapsible sidebar, which requires a change in Sphinx iteself.

Also changed hover color for header links.
@berkerpeksag
Copy link
Member

Sorry for the delay. I'm reviewing this now.

@brettcannon
Copy link
Member

@berkerpeksag is your review done? Otherwise I'm tempted to accept this PR as-is.

@zware zware merged commit 9578fb7 into python:master Nov 2, 2016
@lisroach lisroach deleted the theme-update branch November 2, 2016 03:24
@lisroach
Copy link
Author

lisroach commented Nov 2, 2016

Thank you!

@zware
Copy link
Member

zware commented Nov 2, 2016

Thanks, @lisroach! I changed the hover color to #eee, otherwise the patch was great.

@brettcannon
Copy link
Member

We should probably either do a merge into github or do a cherry pick.

@zware
Copy link
Member

zware commented Nov 2, 2016

Should already be done. There were also a few other outstanding changes on master that were also merged.

@willingc
Copy link
Collaborator

willingc commented Nov 3, 2016

Thanks @zware for the work on merging the outstanding changes on master 😄 I've been slammed with Jupyter stuff lately. Thanks @brettcannon for keeping this on your radar 🎯 😄

@lisroach Congrats! Thanks and great to see this merged: 🎉

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Except for the collapsible sidebar, which requires a change in Sphinx itself.

Also changed hover color for header links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants