-
-
Notifications
You must be signed in to change notification settings - Fork 890
Test results are not saved anywhere. #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarifying that the test results are not saved anywhere.
Hello, and thanks for your contribution! Unfortunately our records indicate you have not signed a PSF contributor agreement (CLA). For legal reasons we need you to sign this before we can look at your contribution. Once you have done everything that's needed, please reply here and someone will verify everything is in order. |
Linked to http://bugs.python.org/issue29047 but i cannot figure out how to add the pull request to the issue tracker correctly |
I have now signed the document.
Regards,
Patrik Iselind
…On Sat, Dec 24, 2016 at 11:52 AM, the-knights-who-say-ni < ***@***.***> wrote:
Hello, and thanks for your contribution!
Unfortunately our records indicate you have not signed a PSF contributor
agreement <https://www.python.org/psf/contrib/contrib-form/> (CLA). For
legal reasons we need you to sign this before we can look at your
contribution.
Once you have done everything that's needed, please reply here and someone
will verify everything is in order.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUIB0dj5-Wxke693Xf1S3mWH1_kkp2AMks5rLPmLgaJpZM4LVNHV>
.
|
Thanks for the PR, but -1 from me. We can't and shouldn't add every small detail to the devguide. The all supported features of the test runner can already be seen by using the |
Agree with Berker. I don't understand why you emphasize the output. And it's obvious that you can redirect the output to store it. |
I for one expected the result to be stored somewhere.
Patrik
Den 24 dec 2016 13:46 skrev "Xiang Zhang" <notifications@github.com>:
… Agree with Berker. I don't understand why you emphasize the output. And
it's obvious that you can redirect the output to store it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUIB0fegajHg9-FR6Nd5qaZJze4Ek27Sks5rLRQjgaJpZM4LVNHV>
.
|
Other new developers might be helped by this as well.
Patrik
Den 24 dec 2016 16:41 skrev "mrx" <patrik.mrx@gmail.com>:
… I for one expected the result to be stored somewhere.
Patrik
Den 24 dec 2016 13:46 skrev "Xiang Zhang" ***@***.***>:
> Agree with Berker. I don't understand why you emphasize the output. And
> it's obvious that you can redirect the output to store it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#88 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AUIB0fegajHg9-FR6Nd5qaZJze4Ek27Sks5rLRQjgaJpZM4LVNHV>
> .
>
|
@berkerpeksag , i'm not saying everything should be repeated. Just this one. |
It's still a fairly weird thing to mention since most, if not all unit testing programs I've encountered simply print out their results to stdout and set the appropriate error code when they return. I guess it helps if you've never encountered unit testing in other projects before. Some examples:
|
Thanks for the PR, @iselind , but the consensus is that this isn't necessary, so I'm closing this. |
I don't know if it's just me but i think that dev docs should cover enough
so that as many as possible can start to help out and not assume a certain
level of experience with this or that.
Patrik Iselind
…On Sat, Dec 24, 2016 at 6:35 PM, Ammar Askar ***@***.***> wrote:
It's still a fairly weird thing to mention since most, if not all unit
testing programs I've encountered simply print out their results to stdout
and set the appropriate error code when they return. I guess it helps if
you've never encountered unit testing in other projects before.
Some examples:
- tox
- unittest module
- rake (for ruby)
- mocha (for js)
- CUnit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUIB0QqimglYlGt1EcaFTpfxay7z74IMks5rLVfcgaJpZM4LVNHV>
.
|
We're not trying to make Python contribution work for any person in the world who may want to help out (e.g. we are not here to teach people how to program). There is a certain level of prior knowledge necessary and we are saying that being able to read the documentation of |
Clarifying that the test results are not saved anywhere.