Skip to content

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 1, 2023

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some things that were not linkified (including in the rendered version), stripped out some comments that were instead treated as call-out quotes, and fixed a couple typoes

Comment on lines +76 to +77
* We're using a personal account (Mariatta's). Not ideal. Right now community version of RtD doesn't support multiple owners, there are workarounds. Organizations are only in the commercial version so far.
* would be nice to have an ORG account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the Docs Community does not support organizations yet. However, it does support multiple maintainers with admin permissions for the same project. As a example, this is how we have configured our own documentation:

Screenshot_2023-06-05_20-51-07

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks, and I believe we use that on our main RTD-hosted/previewed stuff, with at least three-ish people added there for each. If I understand the concern here, though, it is that each project is still technically "owned" by one individual person's personal account, leading to an eventual single point of failure, alongside the inability to centrally manage many different projects with different owners/maintainers owned by one FOSS entity, its all scattered between individual people's accounts.

This because particularly problematic if we end up moving the hosting of the Python docs to RTD, since it means the ultimate responsibility for a docs site that gets tens of millions of hits per month would have to rest on the shoulders of one person.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it would be nice for central management and an org account.

But practically, I'm not too worried about that. The main thing is to make sure enough have admin access to keep the bus factor healthy.

Currently it's just Mariatta and me for the CPython previews. Would any other core devs like access too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a core dev, but for consistency purposes you could add Ee. And if you need an extra person and don't have someone better, you could add me if needed—I'm not actually an admin of any other RTD-hosted project right now, so it would be helpful to have at least one I can get familiar with.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CAM-Gerlach Please create an RtD account, lete know the username, and I'll add you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk Actually seems like I do have a RTD account, under the username CAM-Gerlach, in case you want to add that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAM-Gerlach invited!

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jun 7, 2023

I see @hugovk 's checkmark is gray but mine is green (indicating I have write access but he doesn't)_, despite the fact that he's been one of the most active core devs helping out on docs infra lately. Can he be added to whatever team(s) give him that?

@Mariatta
Copy link
Member

Mariatta commented Jun 7, 2023

The people with write access is those in the docs-triagers team.

@encukou encukou merged commit 83fb3e3 into python:main Jun 15, 2023
@encukou encukou deleted the ma branch June 15, 2023 14:43
@encukou
Copy link
Member Author

encukou commented Jun 15, 2023

I've added core devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants