Skip to content

Conversation

egeakman
Copy link
Contributor

@egeakman egeakman commented Sep 21, 2023

  • Add pre-commit checks
  • Add lint action
  • Fix pre-commit and sphinx-lint complaints

📚 Documentation preview 📚: https://docs-community--87.org.readthedocs.build/en/87/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few suggestions :)

@egeakman
Copy link
Contributor Author

This PR got a little big in terms of file count. Should I open a seperate PR for the fixes after this one?

cc: @hugovk

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR got a little big in terms of file count. Should I open a seperate PR for the fixes after this one?

No, this is fine, there's not too many and they're small changes.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@egeakman egeakman requested a review from hugovk September 22, 2023 10:34
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit 8bd026e into python:main Sep 22, 2023
@egeakman egeakman deleted the pre-commit branch September 22, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants