Skip to content

Clean-up lookup functions in semanal.py #4157

Open
@ilevkivskyi

Description

@ilevkivskyi

Second pass of semantic analysis has 6 lookup functions:

  • lookup
  • lookup_qualified
  • lookup_fully_qualified
  • lookup_fully_qualified_or_none
  • lookup_type_node

plus 3 related helpers:

  • builtin_type
  • named_type
  • named_type_or_none

I think 9 lookup functions is too much and can cause confusions (this happened to me several times). I think we can leave only 3 lookup functions plus 2 helpers.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions