Don't try to follow imports to encodings.* #10094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`encodings` uses module-level `__getattr__`. By not trying to follow imports to the submodules, resolving imports is slightly faster. This is usually pretty marginal, but there can be over 100 suppressed submodules, so this may actually be significant.
ilevkivskyi
approved these changes
Feb 15, 2021
mypy/dmypy_server.py
Outdated
| all_suppressed = {module for module in all_suppressed if module not in graph} | ||
| all_suppressed = {module | ||
| for module in all_suppressed | ||
| if module not in graph and not module.startswith('encodings.')} |
There was a problem hiding this comment.
Maybe make this a top level constant (i.e. a single item list or set), so later we can skip similar "special" modules?
There was a problem hiding this comment.
I'll define a function that contains the check (as a micro-optimization and it also allows other checks than starts with).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodingsuses module-level__getattr__. By not trying to followimports to the submodules, resolving imports is slightly faster.
This is usually pretty marginal, but there can be over 100 suppressed
submodules, so this may actually be significant.