Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest to install stubs with py.typed files #10652

Merged
merged 3 commits into from Jun 16, 2021

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Jun 16, 2021

Description

The pallets libraries are now bundled with a py.typed file. Suggesting to install these stubs only leads to confusion. See python/typeshed#5423 and python/typeshed#5642 for context.

@srittau
Copy link
Contributor Author

srittau commented Jun 16, 2021

I've added cryptography and pyjwt (which was misnamed before) to the list.

@srittau srittau changed the title Don't suggest to install pallets stubs Don't suggest to install stubs with py.typed files Jun 16, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jun 16, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

kopf (https://github.com/nolar/kopf.git)
- kopf/cli.py:6: error: Library stubs not installed for "click" (or incompatible with Python 3.8)
- kopf/_kits/runner.py:8: error: Library stubs not installed for "click.testing" (or incompatible with Python 3.8)
- kopf/_kits/runner.py:8: note: Hint: "python3 -m pip install types-click"
- kopf/_kits/runner.py:8: error: Library stubs not installed for "click" (or incompatible with Python 3.8)

prefect (https://github.com/PrefectHQ/prefect.git)
- src/prefect/utilities/cli.py:4: error: Library stubs not installed for "click" (or incompatible with Python 3.8)
- src/prefect/utilities/cli.py:4: note: Hint: "python3 -m pip install types-click"

core (https://github.com/home-assistant/core.git)
+ homeassistant/util/color.py:587: error: Too many arguments for "XYPoint"  [call-arg]
+ homeassistant/util/color.py:588: error: Too many arguments for "XYPoint"  [call-arg]
+ homeassistant/util/color.py:598: error: Too many arguments for "XYPoint"  [call-arg]
- homeassistant/util/color.py:587: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ homeassistant/util/color.py:609: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
- homeassistant/components/http/auth.py:13: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)  [import]
- homeassistant/helpers/template.py:24: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.8)  [import]
- homeassistant/helpers/template.py:26: error: Library stubs not installed for "jinja2.sandbox" (or incompatible with Python 3.8)  [import]
- homeassistant/helpers/template.py:27: error: Library stubs not installed for "jinja2.utils" (or incompatible with Python 3.8)  [import]
- homeassistant/auth/__init__.py:9: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)  [import]
- homeassistant/auth/__init__.py:9: note: Hint: "python3 -m pip install types-jwt"
- homeassistant/auth/__init__.py:9: note: (or run "mypy --install-types" to install all missing stub packages)
- homeassistant/auth/__init__.py:9: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- homeassistant/components/frontend/__init__.py:13: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.8)  [import]
- homeassistant/components/frontend/__init__.py:13: note: Hint: "python3 -m pip install types-Jinja2"
- homeassistant/helpers/config_entry_oauth2_flow.py:20: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)  [import]
+ homeassistant/auth/mfa_modules/notify.py:12: note: (or run "mypy --install-types" to install all missing stub packages)
+ homeassistant/auth/mfa_modules/notify.py:12: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- homeassistant/components/html5/notify.py:12: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)  [import]

streamlit (https://github.com/streamlit/streamlit.git)
- scripts/run_all_examples.py:20:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ scripts/run_all_examples.py:20:1: error: Cannot find implementation or library stub for module named "click"  [import]
- scripts/run_e2e_tests.py:28:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ scripts/run_e2e_tests.py:28:1: error: Cannot find implementation or library stub for module named "click"  [import]
- scripts/cli_smoke_tests.py:20:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
- lib/streamlit/url_util.py:66:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
- scripts/run_bare_integration_tests.py:31:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ scripts/cli_smoke_tests.py:20:1: error: Cannot find implementation or library stub for module named "click"  [import]
+ lib/streamlit/url_util.py:66:1: error: Cannot find implementation or library stub for module named "click"  [import]
+ scripts/run_bare_integration_tests.py:31:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/config_util.py:4:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/config_util.py:4:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/watcher/file_watcher.py:17:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/watcher/file_watcher.py:17:1: error: Cannot find implementation or library stub for module named "click"  [import]
+ lib/streamlit/__init__.py:70:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/__init__.py:70:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
- lib/streamlit/__init__.py:70:1: note: Hint: "python3 -m pip install types-click"
- lib/streamlit/credentials.py:24:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/credentials.py:24:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/tests/streamlit/watcher/file_watcher_test.py:20:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/tests/streamlit/watcher/file_watcher_test.py:20:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/server/server.py:22:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/server/server.py:22:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/bootstrap.py:20:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/bootstrap.py:20:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/streamlit/cli.py:23:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/streamlit/cli.py:23:1: error: Cannot find implementation or library stub for module named "click"  [import]
- lib/tests/streamlit/cli_test.py:26:1: error: Library stubs not installed for "click.testing" (or incompatible with Python 3.8)  [import]
+ lib/tests/streamlit/cli_test.py:26:1: error: Cannot find implementation or library stub for module named "click.testing"  [import]
- lib/tests/streamlit/bootstrap_test.py:23:1: error: Library stubs not installed for "click" (or incompatible with Python 3.8)  [import]
+ lib/tests/streamlit/bootstrap_test.py:23:1: error: Cannot find implementation or library stub for module named "click"  [import]

dragonchain (https://github.com/dragonchain/dragonchain.git)
- dragonchain/webserver/helpers.py:22:1: error: Library stubs not installed for "werkzeug" (or incompatible with Python 3.8)
- dragonchain/webserver/helpers.py:22:1: note: Hint: "python3 -m pip install types-Werkzeug"
- dragonchain/webserver/request_authorizer.py:21:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/verifications.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/misc.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/interchain.py:21:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/blocks.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/api_keys.py:21:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/transaction_types.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/smart_contracts.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/transactions.py:21:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/dragonnet.py:21:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/__init__.py:39:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- dragonchain/webserver/routes/__init__.py:39:1: note: Hint: "python3 -m pip install types-Flask"
- dragonchain/webserver/app.py:20:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
+ dragonchain/job_processor/contract_job_utest.py:467:38: error: Incompatible types in assignment (expression has type "BuildTaskResult", variable has type "SmartContractModel")
+ dragonchain/job_processor/contract_job_utest.py:468:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:469:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:478:31: error: Incompatible types in assignment (expression has type "BuildTaskResultWithHelpers", variable has type "SmartContractModel")
+ dragonchain/job_processor/contract_job_utest.py:479:38: error: Incompatible types in assignment (expression has type "BuildTaskResultWithHelpers", variable has type "SmartContractModel")
+ dragonchain/job_processor/contract_job_utest.py:486:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:487:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:488:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:489:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:490:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:491:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:502:13: error: "Callable[[], None]" has no attribute "assert_called"
+ dragonchain/job_processor/contract_job_utest.py:508:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:509:9: error: Cannot assign to a method
+ dragonchain/job_processor/contract_job_utest.py:510:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:467:468: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ dragonchain/job_processor/contract_job_utest.py:511:512: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)

scrapy (https://github.com/scrapy/scrapy.git)
- tests/keys/__init__.py:4: error: Library stubs not installed for "cryptography.hazmat.backends" (or incompatible with Python 3.8)
- tests/keys/__init__.py:5: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric" (or incompatible with Python 3.8)
- tests/keys/__init__.py:6: error: Library stubs not installed for "cryptography.hazmat.primitives.hashes" (or incompatible with Python 3.8)
- tests/keys/__init__.py:7: error: Library stubs not installed for "cryptography.hazmat.primitives.serialization" (or incompatible with Python 3.8)
- tests/keys/__init__.py:12: error: Library stubs not installed for "cryptography.x509" (or incompatible with Python 3.8)
- tests/keys/__init__.py:20: error: Library stubs not installed for "cryptography.x509.oid" (or incompatible with Python 3.8)
- scrapy/utils/versions.py:4: error: Library stubs not installed for "cryptography" (or incompatible with Python 3.8)
- scrapy/utils/versions.py:4: note: Hint: "python3 -m pip install types-cryptography"
- scrapy/utils/versions.py:4: note: (or run "mypy --install-types" to install all missing stub packages)
- scrapy/utils/versions.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ scrapy/cmdline.py:6: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/cmdline.py:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- tests/test_webclient.py:10: error: Library stubs not installed for "cryptography" (or incompatible with Python 3.8)

freqtrade (https://github.com/freqtrade/freqtrade.git)
- freqtrade/misc.py:185: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.8)
- freqtrade/misc.py:200: error: Library stubs not installed for "jinja2.exceptions" (or incompatible with Python 3.8)
- freqtrade/commands/build_config_commands.py:188: error: Library stubs not installed for "jinja2.exceptions" (or incompatible with Python 3.8)
- freqtrade/commands/build_config_commands.py:188: note: Hint: "python3 -m pip install types-Jinja2"
- freqtrade/commands/build_config_commands.py:188: note: (or run "mypy --install-types" to install all missing stub packages)
- freqtrade/commands/build_config_commands.py:188: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ freqtrade/commands/data_commands.py:113: note: (or run "mypy --install-types" to install all missing stub packages)
+ freqtrade/commands/data_commands.py:113: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- freqtrade/rpc/api_server/api_auth.py:4: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)
- freqtrade/rpc/api_server/api_auth.py:4: note: Hint: "python3 -m pip install types-jwt"

aiortc (https://github.com/aiortc/aiortc)
- src/aiortc/rtcdtlstransport.py:13: error: Library stubs not installed for "cryptography" (or incompatible with Python 3.8)
- src/aiortc/rtcdtlstransport.py:13: note: Hint: "python3 -m pip install types-cryptography"
- src/aiortc/rtcdtlstransport.py:13: note: (or run "mypy --install-types" to install all missing stub packages)
- src/aiortc/rtcdtlstransport.py:13: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- src/aiortc/rtcdtlstransport.py:14: error: Library stubs not installed for "cryptography.hazmat.backends" (or incompatible with Python 3.8)
- src/aiortc/rtcdtlstransport.py:15: error: Library stubs not installed for "cryptography.hazmat.bindings.openssl.binding" (or incompatible with Python 3.8)
- src/aiortc/rtcdtlstransport.py:16: error: Library stubs not installed for "cryptography.hazmat.primitives" (or incompatible with Python 3.8)
- src/aiortc/rtcdtlstransport.py:17: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric" (or incompatible with Python 3.8)

pandas (https://github.com/pandas-dev/pandas.git)
- pandas/io/formats/style_render.py:44: error: Library stubs not installed for "markupsafe" (or incompatible with Python 3.8)  [import]
- pandas/io/formats/style_render.py:44: note: Hint: "python3 -m pip install types-MarkupSafe"

sphinx (https://github.com/sphinx-doc/sphinx.git)
- sphinx/util/tags.py:11:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/util/tags.py:12:1: error: Library stubs not installed for "jinja2.environment" (or incompatible with Python 3.6)
- sphinx/util/tags.py:13:1: error: Library stubs not installed for "jinja2.nodes" (or incompatible with Python 3.6)
- sphinx/util/tags.py:14:1: error: Library stubs not installed for "jinja2.parser" (or incompatible with Python 3.6)
- sphinx/util/rst.py:21:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/util/rst.py:27:1: error: Library stubs not installed for "jinja2.utils" (or incompatible with Python 3.6)
- sphinx/util/__init__.py:219:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/jinja2glue.py:15:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/jinja2glue.py:16:1: error: Library stubs not installed for "jinja2.environment" (or incompatible with Python 3.6)
- sphinx/jinja2glue.py:17:1: error: Library stubs not installed for "jinja2.sandbox" (or incompatible with Python 3.6)
- sphinx/jinja2glue.py:18:1: error: Library stubs not installed for "jinja2.utils" (or incompatible with Python 3.6)
- sphinx/util/template.py:16:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/util/template.py:17:1: error: Library stubs not installed for "jinja2.environment" (or incompatible with Python 3.6)
- sphinx/util/template.py:18:1: error: Library stubs not installed for "jinja2.loaders" (or incompatible with Python 3.6)
- sphinx/util/template.py:19:1: error: Library stubs not installed for "jinja2.sandbox" (or incompatible with Python 3.6)
- sphinx/ext/autosummary/generate.py:33:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- sphinx/ext/autosummary/generate.py:33:1: note: Hint: "python3 -m pip install types-Jinja2"
- sphinx/ext/autosummary/generate.py:34:1: error: Library stubs not installed for "jinja2.sandbox" (or incompatible with Python 3.6)

PyGithub (https://github.com/PyGithub/PyGithub.git)
+ tests/GithubIntegration.py:7: error: Cannot find implementation or library stub for module named "jwt"
- tests/GithubIntegration.py:7: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)
- tests/GithubIntegration.py:7: note: Hint: "python3 -m pip install types-jwt"

starlette (https://github.com/encode/starlette.git)
+ starlette/responses.py:21: note: (or run "mypy --install-types" to install all missing stub packages)
+ starlette/responses.py:21: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- starlette/templating.py:8: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.8)
- starlette/templating.py:8: note: Hint: "python3 -m pip install types-Jinja2"
- starlette/middleware/sessions.py:5: error: Library stubs not installed for "itsdangerous" (or incompatible with Python 3.8)
- starlette/middleware/sessions.py:5: note: Hint: "python3 -m pip install types-itsdangerous"
- starlette/middleware/sessions.py:5: note: (or run "mypy --install-types" to install all missing stub packages)
- starlette/middleware/sessions.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- starlette/middleware/sessions.py:6: error: Library stubs not installed for "itsdangerous.exc" (or incompatible with Python 3.8)

manticore (https://github.com/trailofbits/manticore.git)
- tests/wasm_sym/json2smc.py:3: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- tests/wasm/json2mc.py:3: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.6)
- tests/wasm/json2mc.py:3: note: Hint: "python3 -m pip install types-Jinja2"
+ manticore/wasm/structure.py:395: error: Too many arguments for "Import"
- manticore/wasm/structure.py:398: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ manticore/wasm/structure.py:395: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ manticore/wasm/structure.py:398: error: Too many arguments for "LimitType"

black (https://github.com/psf/black.git)
- src/black/output.py:10:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)
- src/black/report.py:8:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)
- src/black_primer/lib.py:18:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)
- src/black_primer/cli.py:12:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)
- src/black/__init__.py:30:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)
- src/black/__init__.py:30:1: note: Hint: "python3 -m pip install types-click"
- src/blackd/__init__.py:24:1: error: Library stubs not installed for "click" (or incompatible with Python 3.6)

pyjwt (https://github.com/jpadilla/pyjwt.git)
- jwt/utils.py:6: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric.ec" (or incompatible with Python 3.6)
- jwt/utils.py:7: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric.utils" (or incompatible with Python 3.6)
- jwt/algorithms.py:17: error: Library stubs not installed for "cryptography.exceptions" (or incompatible with Python 3.6)
- jwt/algorithms.py:17: note: Hint: "python3 -m pip install types-cryptography"
- jwt/algorithms.py:17: note: (or run "mypy --install-types" to install all missing stub packages)
- jwt/algorithms.py:17: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- jwt/algorithms.py:17: error: Library stubs not installed for "cryptography" (or incompatible with Python 3.6)
- jwt/algorithms.py:19: error: Library stubs not installed for "cryptography.hazmat.primitives" (or incompatible with Python 3.6)
- jwt/algorithms.py:20: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric" (or incompatible with Python 3.6)
- jwt/algorithms.py:21: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric.ec" (or incompatible with Python 3.6)
- jwt/algorithms.py:25: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric.ed25519" (or incompatible with Python 3.6)
- jwt/algorithms.py:29: error: Library stubs not installed for "cryptography.hazmat.primitives.asymmetric.rsa" (or incompatible with Python 3.6)
- jwt/algorithms.py:39: error: Library stubs not installed for "cryptography.hazmat.primitives.serialization" (or incompatible with Python 3.6)
- jwt/help.py:8: error: Library stubs not installed for "cryptography" (or incompatible with Python 3.6)

bokeh (https://github.com/bokeh/bokeh.git)
- bokeh/io/saving.py:29:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.7)  [import]
+ bokeh/io/saving.py:29:1: error: Cannot find implementation or library stub for module named "jinja2"  [import]
+ bokeh/embed/standalone.py:38:1: error: Cannot find implementation or library stub for module named "jinja2"  [import]
- bokeh/embed/standalone.py:38:1: error: Library stubs not installed for "jinja2" (or incompatible with Python 3.7)  [import]
- bokeh/embed/standalone.py:38:1: note: Hint: "python3 -m pip install types-Jinja2"

alerta (https://github.com/alerta/alerta.git)
- alerta/utils/config.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/hmac.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/exceptions.py:4: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/exceptions.py:5: error: Library stubs not installed for "werkzeug.exceptions" (or incompatible with Python 3.8)
- alerta/exceptions.py:6: error: Library stubs not installed for "werkzeug.routing" (or incompatible with Python 3.8)
- alerta/utils/response.py:4: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/database/base.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/tracing.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/paging.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/paging.py:2: error: Library stubs not installed for "werkzeug.datastructures" (or incompatible with Python 3.8)
- alerta/utils/logging.py:6: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/token.py:4: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)
- alerta/models/token.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/key.py:7: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/mailer.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/webhook.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/hooks.py:2: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/format.py:6: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/plugin.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/utils/audit.py:8: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/app.py:4: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/app.py:8: error: Library stubs not installed for "werkzeug.middleware.proxy_fix" (or incompatible with Python 3.8)
- alerta/models/permission.py:4: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/note.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/heartbeat.py:9: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/blackout.py:6: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alert.py:9: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/utils.py:6: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/utils.py:7: error: Library stubs not installed for "itsdangerous" (or incompatible with Python 3.8)
- alerta/auth/utils.py:7: note: Hint: "python3 -m pip install types-itsdangerous"
- alerta/auth/utils.py:30: error: Library stubs not installed for "werkzeug.security" (or incompatible with Python 3.8)
- alerta/auth/utils.py:30: note: Hint: "python3 -m pip install types-Werkzeug"
- alerta/utils/api.py:4: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/user.py:6: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/decorators.py:7: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/decorators.py:8: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)
- alerta/auth/decorators.py:8: note: Hint: "python3 -m pip install types-jwt"
- alerta/auth/basic_ldap.py:2: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/webhooks/__init__.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/webhooks/__init__.py:6: error: Library stubs not installed for "werkzeug.datastructures" (or incompatible with Python 3.8)
- alerta/webhooks/custom.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/__init__.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/users.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/permissions.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/oembed.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/keys.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/heartbeats.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/groups.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/customers.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/config.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/blackouts.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/alerts.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/views/bulk.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/management/__init__.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/management/views.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/__init__.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/__init__.py:1: note: Hint: "python3 -m pip install types-Flask"
- alerta/auth/__init__.py:1: note: (or run "mypy --install-types" to install all missing stub packages)
- alerta/auth/__init__.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- alerta/auth/userinfo.py:3: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/oidc.py:3: error: Library stubs not installed for "jwt" (or incompatible with Python 3.8)
- alerta/auth/oidc.py:5: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/logout.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/auth/login.py:1: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
+ alerta/auth/github.py:1: note: (or run "mypy --install-types" to install all missing stub packages)
+ alerta/auth/github.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- alert```

@srittau
Copy link
Contributor Author

srittau commented Jun 16, 2021

The primer output mostly removes warnings about missing stubs, as expected. Apart from that the differences are mostly due to differences between typeshed's stubs and the annotations in the packages.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Jun 16, 2021

Ideally we should still suggest these stubs if users are using an old version of Click that doesn't have py.typed yet. But that's probably too complicated to make sense.

@cjolowicz
Copy link
Contributor

cjolowicz commented Jun 16, 2021

Ideally we should still suggest these stubs if users are using an old version of Click that doesn't have py.typed yet. But that's probably too complicated to make sense.

The stubs are not suggested if click >= 8.0 is installed:

❯ venv/bin/mypy <(echo "import click")

/dev/fd/63:1: error: Library stubs not installed for "click" (or incompatible with Python 3.9)
/dev/fd/63:1: note: Hint: "python3 -m pip install types-click"
/dev/fd/63:1: note: (or run "mypy --install-types" to install all missing stub packages)
/dev/fd/63:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)

❯ venv/bin/pip install click 

Collecting click
  Using cached click-8.0.1-py3-none-any.whl (97 kB)
Installing collected packages: click
Successfully installed click-8.0.1

❯ venv/bin/mypy <(echo "import click")

Success: no issues found in 1 source file

But people who upgrade mypy before upgrading click can be misled by the warning.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Jun 16, 2021

Oh, nice! Then I don't see any problems with this PR. Perhaps mypy should also warn if it sees both types-click and click with a py.typed, but that's a different problem.

@JelleZijlstra JelleZijlstra merged commit 4dd954f into python:master Jun 16, 2021
6 checks passed
@srittau srittau deleted the pallets-stubs branch Jun 16, 2021
@JukkaL JukkaL mentioned this pull request Jun 17, 2021
JukkaL pushed a commit that referenced this pull request Jun 21, 2021
The pallets libraries are now bundled with a `py.typed` file. Suggesting to install these stubs only leads to confusion. See python/typeshed#5423 and python/typeshed#5642 for context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants