Skip to content

Fixes crash on subclassing Annotated without args #11814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fixes crash on subclassing Annotated without args #11814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mypy/typeanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,9 @@ def visit_unbound_type(self, t: UnboundType) -> TypeVarLikeList:
return []
elif node and node.fullname in ('typing_extensions.Literal', 'typing.Literal'):
return []
elif node and node.fullname in ('typing_extensions.Annotated', 'typing.Annotated'):
elif (node
and node.fullname in ('typing_extensions.Annotated', 'typing.Annotated')
and t.args):
# Don't query the second argument to Annotated for TypeVars
return self.query_types([t.args[0]])
else:
Expand Down
7 changes: 7 additions & 0 deletions test-data/unit/semanal-errors.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,3 +1435,10 @@ TP = ParamSpec('?') # E: String argument 1 "?" to ParamSpec(...) does not match
TP2: int = ParamSpec('TP2') # E: Cannot declare the type of a parameter specification

[out]


[case testBaseClassAnnotatedWithoutArgs]
# https://github.com/python/mypy/issues/11808
from typing_extensions import Annotated
# Nest line should not crash:
class A(Annotated): pass # E: Annotated[...] must have exactly one type argument and at least one annotation