-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Adds __version_info__
tuple
#12152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adds __version_info__
tuple
#12152
Conversation
Related #12149
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks good, but I noticed you haven't addressed |
Good catch! |
This comment has been minimized.
This comment has been minimized.
1 similar comment
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
||
|
||
__version__ = build_version(__version_info__, __version_release_level__) | ||
base_version = __version__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will generate an incorrect base_version
including the git hash
If the purpose of this change is to make plugin version parsing easier, should there be a deprecation cycle to send the |
I guess this is the next step 🙂 |
We don't require a deprecation period for plugin API changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base_version shouldn't include git hash, as KotlinIsland points out. There are also merge conflicts.
While we don't require a deprecation period for plugin API changes, we need to be careful about breaking things here, since allowing plugins to branch on version is what enables us to play fast and loose with breaking plugins.
Alternative to #12149
Closes #12145