Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubgen: Fix non default keyword-only argument positioning (#11082) #12303

Merged
merged 1 commit into from Mar 8, 2022

Conversation

shoracek
Copy link
Contributor

@shoracek shoracek commented Mar 7, 2022

Description

Moves the asterisk logic so that it is processed right away even if the following argument does not have a default value.

Fixes #11082

Test Plan

I added the example from the issue as a unit test.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 7, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Awesome, thank you!

@hauntsaninja hauntsaninja merged commit 8650f5c into python:master Mar 8, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants