Remove the * for inferred types from reveal_type output #12459
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks for updating so many tests! It all looks good to me.
CI is failing because of issues with mypyc on Windows. Not sure what that's about but it's probably not related to this change.
@JukkaL could you confirm whether you're OK with removing the * for inferred types from mypy's output?
|
Yeah, this is good! The asterisks have been useless. I originally thought that mypyc would benefit from them, but it doesn't really need them for anything, I think. Windows CI was fixed recently -- if you rebase, it should work. |
|
Thanks @JukkaL! In the repo settings, there is an option to allow updating branches from the UI, could you enable that? It would allow fixing CI in cases like this without using the command line. |
|
@JelleZijlstra thanks for reviewing, i'm very glad to help. Should i rebase myself? |
|
@stkrizh sure! |
stkrizh
force-pushed
the
reveal-type-remove-asterisk
branch
from
df9960c to
c64f400
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was an upstream change (python/mypy#12459) to remove * from inferred types in the reveal_type output. As we are asserting the * to exist, all the test cases are now failing on the 0.950 release. Removing the expected * to mirror the upstream behaviour change should resolve the test failures.
* Bump mypy to 0.95x * Remove the * for inferred types There was an upstream change (python/mypy#12459) to remove * from inferred types in the reveal_type output. As we are asserting the * to exist, all the test cases are now failing on the 0.950 release. Removing the expected * to mirror the upstream behaviour change should resolve the test failures.
Description
This PR removes
*fromreveal_typeoutput for inferred types.Closes #10076
Test Plan
Tests are updated accordingly.
*is also removed from expected test outputs.