Show error codes by default #13542

cdce8p · 2022-08-28T11:21:59Z

Description

Part of the effort to nudge users into using specific type ignores. See #13541

This PR enables show-error-codes by default. Without knowing the code, users will always choose to use a bare type: ignore instead.

hauntsaninja

~~We shouldn't break show_error_codes = ... in existing configs. It looks like command line already supports that, but config doesn't. Try taking a look at~~

mypy/mypy/config_parser.py

Line 434 in 80c09d5

elif key.startswith("disallow") and hasattr(template, key[3:]):

Edit: Looks like you're faster than I am :-)

sobolevn

Couple of thoughts:

I don't really like --hide-error-codes new config value. I would prefer to keep just --show-error-code with new default, that can be used as --show-error-code=False to fallback to the old way. Current configuration leaves too much space for potential errors: what if I have both? What if I have --show-error-code=False or --hide-error-code=True?
This will require to pay extra attention to error codes from mypy team (which is a good thing). Since this change we would need to consider error code changes as breaking changes (probably) 🤔

docs/source/config_file.rst

sobolevn · 2022-09-27T09:43:55Z

mypyc/errors.py

        self.num_errors = 0
        self.num_warnings = 0
-        self._errors = mypy.errors.Errors()
+        self._errors = mypy.errors.Errors(hide_error_codes=True)


Why do we need this change? 🤔

The PR would have enabled error codes for mypyc as well which resulted in a lot of failing tests. I'm not sure if we should do that too. The main focus was to enable it for mypy runs which is why I added hide_error_codes=True here.

sobolevn · 2022-09-27T09:44:34Z

test-data/unit/check-errorcodes.test

+
+[file mypy.ini]
+\[mypy]
+show_error_codes = True


Do we need a test for hide_error_code = False / True?

I've already added one in check-flags.test right at the end.

github-actions · 2022-09-27T12:44:32Z

Diff from mypy_primer, showing the effect of this PR on open source code:

aiortc (https://github.com/aiortc/aiortc)
- src/aiortc/rtp.py:326: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ src/aiortc/rtp.py:326: error: Incompatible types in assignment (expression has type "float", variable has type "int")  [assignment]
- src/aiortc/rtp.py:326: error: "AudioFrame" has no attribute "samples"
+ src/aiortc/rtp.py:326: error: "AudioFrame" has no attribute "samples"  [attr-defined]
- src/aiortc/contrib/media.py:236: error: Call to untyped function "stop" in typed context
+ src/aiortc/contrib/media.py:236: error: Call to untyped function "stop" in typed context  [no-untyped-call]
- src/aiortc/contrib/media.py:239: error: "Frame" has no attribute "time"
+ src/aiortc/contrib/media.py:239: error: "Frame" has no attribute "time"  [attr-defined]
- src/aiortc/codecs/h264.py:282: error: "VideoFrame" has no attribute "pict_type"
+ src/aiortc/codecs/h264.py:282: error: "VideoFrame" has no attribute "pict_type"  [attr-defined]
- src/aiortc/codecs/h264.py:282: error: Module has no attribute "video"
+ src/aiortc/codecs/h264.py:282: error: Module has no attribute "video"  [attr-defined]
- src/aiortc/rtcrtpreceiver.py:498: error: Invalid index type "Union[int, str, None]" for "Dict[int, RTCRtpCodecParameters]"; expected type "int"
+ src/aiortc/rtcrtpreceiver.py:498: error: Invalid index type "Union[int, str, None]" for "Dict[int, RTCRtpCodecParameters]"; expected type "int"  [index]
- src/aiortc/rtcpeerconnection.py:92: error: Invalid index type "Union[int, str, None]" for "Dict[int, RTCRtpCodecParameters]"; expected type "int"
+ src/aiortc/rtcpeerconnection.py:92: error: Invalid index type "Union[int, str, None]" for "Dict[int, RTCRtpCodecParameters]"; expected type "int"  [index]
- src/aiortc/rtcpeerconnection.py:138: error: Argument 1 to "parse_h264_profile_level_id" has incompatible type "Union[int, str]"; expected "str"
+ src/aiortc/rtcpeerconnection.py:138: error: Argument 1 to "parse_h264_profile_level_id" has incompatible type "Union[int, str]"; expected "str"  [arg-type]
- src/aiortc/rtcpeerconnection.py:1135: error: Invalid index type "Union[int, str]" for "Dict[int, RTCRtpDecodingParameters]"; expected type "int"
+ src/aiortc/rtcpeerconnection.py:1135: error: Invalid index type "Union[int, str]" for "Dict[int, RTCRtpDecodingParameters]"; expected type "int"  [index]

pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/frame.py:126: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ pyinstrument/frame.py:126: error: Incompatible types in assignment (expression has type "float", variable has type "int")  [assignment]
- pyinstrument/frame.py:135: error: Missing return statement
+ pyinstrument/frame.py:135: error: Missing return statement  [return]
- pyinstrument/frame.py:140: error: Missing return statement
+ pyinstrument/frame.py:140: error: Missing return statement  [return]
- pyinstrument/frame.py:201: error: Missing return statement
+ pyinstrument/frame.py:201: error: Missing return statement  [return]
- pyinstrument/frame.py:206: error: Name "attributes" already defined on line 57
+ pyinstrument/frame.py:206: error: Name "attributes" already defined on line 57  [no-redef]
- pyinstrument/frame.py:259: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ pyinstrument/frame.py:259: error: Incompatible types in assignment (expression has type "float", variable has type "int")  [assignment]
- pyinstrument/frame.py:262: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ pyinstrument/frame.py:262: error: Incompatible types in assignment (expression has type "float", variable has type "int")  [assignment]
- pyinstrument/vendor/appdirs.py:533: error: Cannot find implementation or library stub for module named "com.sun"
+ pyinstrument/vendor/appdirs.py:533: error: Cannot find implementation or library stub for module named "com.sun"  [import]
- pyinstrument/vendor/appdirs.py:534: error: Cannot find implementation or library stub for module named "com.sun.jna.platform"
+ pyinstrument/vendor/appdirs.py:534: error: Cannot find implementation or library stub for module named "com.sun.jna.platform"  [import]
- pyinstrument/vendor/appdirs.py:559: error: Module "ctypes" has no attribute "windll"
+ pyinstrument/vendor/appdirs.py:559: error: Module "ctypes" has no attribute "windll"  [attr-defined]
- pyinstrument/vendor/appdirs.py:562: error: Cannot find implementation or library stub for module named "com.sun.jna"
+ pyinstrument/vendor/appdirs.py:562: error: Cannot find implementation or library stub for module named "com.sun.jna"  [import]
- pyinstrument/vendor/appdirs.py:562: error: Cannot find implementation or library stub for module named "com"
+ pyinstrument/vendor/appdirs.py:562: error: Cannot find implementation or library stub for module named "com"  [import]
- pyinstrument/stack_sampler.py:185: error: Incompatible types in string interpolation (expression has type "Optional[int]", placeholder has type "Union[int, float, SupportsInt]")
+ pyinstrument/stack_sampler.py:185: error: Incompatible types in string interpolation (expression has type "Optional[int]", placeholder has type "Union[int, float, SupportsInt]")  [str-format]
- pyinstrument/stack_sampler.py:196: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type
+ pyinstrument/stack_sampler.py:196: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type  [valid-type]
- pyinstrument/stack_sampler.py:196: error: Name "in_context" is not defined
+ pyinstrument/stack_sampler.py:196: error: Name "in_context" is not defined  [name-defined]
- pyinstrument/stack_sampler.py:196: error: Name "out_of_context_awaited" is not defined
+ pyinstrument/stack_sampler.py:196: error: Name "out_of_context_awaited" is not defined  [name-defined]
- pyinstrument/stack_sampler.py:196: error: Name "out_of_context_unknown" is not defined
+ pyinstrument/stack_sampler.py:196: error: Name "out_of_context_unknown" is not defined  [name-defined]
- pyinstrument/frame_ops.py:70: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type
+ pyinstrument/frame_ops.py:70: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type  [valid-type]
- pyinstrument/frame_ops.py:70: error: Name "children" is not defined
+ pyinstrument/frame_ops.py:70: error: Name "children" is not defined  [name-defined]
- pyinstrument/frame_ops.py:70: error: Name "self_time" is not defined
+ pyinstrument/frame_ops.py:70: error: Name "self_time" is not defined  [name-defined]
- pyinstrument/frame_ops.py:70: error: Name "nothing" is not defined
+ pyinstrument/frame_ops.py:70: error: Name "nothing" is not defined  [name-defined]
- pyinstrument/vendor/decorator.py:55: error: All conditional function variants must have identical signatures
+ pyinstrument/vendor/decorator.py:55: error: All conditional function variants must have identical signatures  [misc]
- pyinstrument/vendor/decorator.py:66: error: Incompatible redefinition (redefinition with type "Callable[[Any], Any]", original type overloaded function)
+ pyinstrument/vendor/decorator.py:66: error: Incompatible redefinition (redefinition with type "Callable[[Any], Any]", original type overloaded function)  [misc]
- pyinstrument/vendor/decorator.py:279: error: Module "contextlib" has no attribute "GeneratorContextManager"; maybe "_GeneratorContextManager", "_AsyncGeneratorContextManager", or "AbstractContextManager"?
+ pyinstrument/vendor/decorator.py:279: error: Module "contextlib" has no attribute "GeneratorContextManager"; maybe "_GeneratorContextManager", "_AsyncGeneratorContextManager", or "AbstractContextManager"?  [attr-defined]
- pyinstrument/vendor/decorator.py:279: error: Name "_GeneratorContextManager" already defined (possibly by an import)
+ pyinstrument/vendor/decorator.py:279: error: Name "_GeneratorContextManager" already defined (possibly by an import)  [no-redef]
- pyinstrument/vendor/decorator.py:295: error: Cannot assign to a method
+ pyinstrument/vendor/decorator.py:295: error: Cannot assign to a method  [assignment]
- pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], Tuple[Any, ...], Dict[str, Any]], None]")
+ pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], Tuple[Any, ...], Dict[str, Any]], None]")  [assignment]
- pyinstrument/vendor/decorator.py:301: error: Cannot assign to a method
+ pyinstrument/vendor/decorator.py:301: error: Cannot assign to a method  [assignment]
- pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], Tuple[Any, ...], Dict[str, Any]], None]")
+ pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], Tuple[Any, ...], Dict[str, Any]], None]")  [assignment]
- pyinstrument/profiler.py:46: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type
+ pyinstrument/profiler.py:46: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type  [valid-type]
- pyinstrument/profiler.py:48: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type
+ pyinstrument/profiler.py:48: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type  [valid-type]
- pyinstrument/profiler.py:69: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type
+ pyinstrument/profiler.py:69: error: Variable "pyinstrument.profiler.AsyncMode" is not valid as a type  [valid-type]
- pyinstrument/renderers/console.py:25: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type
+ pyinstrument/renderers/console.py:25: error: Variable "pyinstrument.typing.LiteralStr" is not valid as a type  [valid-type]
- pyinstrument/renderers/console.py:25: error: Name "seconds" is not defined
+ pyinstrument/renderers/console.py:25: error: Name "seconds" is not defined  [name-defined]
- pyinstrument/renderers/console.py:25: error: Name "percent_of_total" is not defined
+ pyinstrument/renderers/console.py:25: error: Name "percent_of_total" is not defined  [name-defined]
- pyinstrument/renderers/console.py:88: error: "Type[object]" has no attribute "end"
+ pyinstrument/renderers/console.py:88: error: "Type[object]" has no attribute "end"  [attr-defined]
- pyinstrument/renderers/console.py:90: error: "Type[object]" has no attribute "end"
+ pyinstrument/renderers/console.py:90: error: "Type[object]" has no attribute "end"  [attr-defined]
- pyinstrument/renderers/console.py:100: error: "Type[object]" has no attribute "end"
+ pyinstrument/renderers/console.py:100: error: "Type[object]" has no attribute "end"  [attr-defined]
- pyinstrument/renderers/console.py:100: error: "Type[object]" has no attribute "faint"
+ pyinstrument/renderers/console.py:100: error: "Type[object]" has no attribute "faint"  [attr-defined]
- pyinstrument/renderers/console.py:115: error: "Type[object]" has no attribute "faint"
+ pyinstrument/renderers/console.py:115: error: "Type[object]" has no attribute "faint"  [attr-defined]
- pyinstrument/renderers/console.py:115: error: "Type[object]" has no attribute "end"
+ pyinstrument/renderers/console.py:115: error: "Type[object]" has no attribute "end"  [attr-defined]
- pyinstrument/renderers/console.py:148: error: "Type[object]" has no attribute "red"
+ pyinstrument/renderers/console.py:148: error: "Type[object]" has no attribute "red"  [attr-defined]
- pyinstrument/renderers/console.py:150: error: "Type[object]" has no attribute "yellow"
+ pyinstrument/renderers/console.py:150: error: "Type[object]" has no attribute "yellow"  [attr-defined]
- pyinstrument/renderers/console.py:152: error: "Type[object]" has no attribute "green"
+ pyinstrument/renderers/console.py:152: error: "Type[object]" has no attribute "green"  [attr-defined]
- pyinstrument/renderers/console.py:154: error: "Type[object]" has no attribute "bright_green"
+ pyinstrument/renderers/console.py:154: error: "Type[object]" has no attribute "bright_green"  [attr-defined]
- pyinstrument/renderers/console.py:154: error: "Type[object]" has no attribute "faint"
+ pyinstrument/renderers/console.py:154: error: "Type[object]" has no attribute "faint"  [attr-defined]
- pyinstrument/renderers/console.py:158: error: "Type[object]" has no attribute "bg_dark_blue_255"
+ pyinstrument/renderers/console.py:158: error: "Type[object]" has no attribute "bg_dark_blue_255"  [attr-defined]
- pyinstrument/renderers/console.py:158: error: "Type[object]" has no attribute "white_255"
+ pyinstrument/renderers/console.py:158: error: "Type[object]" has no attribute "white_255"  [attr-defined]
- pyinstrument/magic/magic.py:5: error: Cannot find implementation or library stub for module named "IPython.core.magic"
+ pyinstrument/magic/magic.py:5: error: Cannot find implementation or library stub for module named "IPython.core.magic"  [import]
- pyinstrument/magic/magic.py:6: error: Cannot find implementation or library stub for module named "IPython.core.magic_arguments"
+ pyinstrument/magic/magic.py:6: error: Cannot find implementation or library stub for module named "IPython.core.magic_arguments"  [import]
- pyinstrument/magic/magic.py:7: error: Cannot find implementation or library stub for module named "IPython.display"
+ pyinstrument/magic/magic.py:7: error: Cannot find implementation or library stub for module named "IPython.display"  [import]
- pyinstrument/middleware.py:6: error: Cannot find implementation or library stub for module named "django.conf"
+ pyinstrument/middleware.py:6: error: Cannot find implementation or library stub for module named "django.conf"  [import]
- pyinstrument/middleware.py:7: error: Cannot find implementation or library stub for module named "django.http"
+ pyinstrument/middleware.py:7: error: Cannot find implementation or library stub for module named "django.http"  [import]
- pyinstrument/middleware.py:8: error: Cannot find implementation or library stub for module named "django.utils.module_loading"
+ pyinstrument/middleware.py:8: error: Cannot find implementation or library stub for module named "django.utils.module_loading"  [import]
- pyinstrument/middleware.py:15: error: Cannot find implementation or library stub for module named "django.utils.deprecation"
+ pyinstrument/middleware.py:15: error: Cannot find implementation or library stub for module named "django.utils.deprecation"  [import]

apprise (https://github.com/caronc/apprise)
- setup.py:31: error: Skipping analyzing "setuptools": module is installed, but missing library stubs or py.typed marker
+ setup.py:31: error: Skipping analyzing "setuptools": module is installed, but missing library stubs or py.typed marker  [import]
- setup.py:40: error: Library stubs not installed for "babel.messages"
+ setup.py:40: error: Library stubs not installed for "babel.messages"  [import]
- apprise/logger.py:34: error: Module has no attribute "TRACE"
+ apprise/logger.py:34: error: Module has no attribute "TRACE"  [attr-defined]
- apprise/logger.py:38: error: Module has no attribute "DEPRECATE"
+ apprise/logger.py:38: error: Module has no attribute "DEPRECATE"  [attr-defined]
- apprise/logger.py:41: error: Module has no attribute "DEPRECATE"
+ apprise/logger.py:41: error: Module has no attribute "DEPRECATE"  [attr-defined]
- apprise/logger.py:42: error: Module has no attribute "TRACE"
+ apprise/logger.py:42: error: Module has no attribute "TRACE"  [attr-defined]
- apprise/logger.py:62: error: "Type[Logger]" has no attribute "trace"
+ apprise/logger.py:62: error: "Type[Logger]" has no attribute "trace"  [attr-defined]
- apprise/logger.py:63: error: "Type[Logger]" has no attribute "deprecate"
+ apprise/logger.py:63: error: "Type[Logger]" has no attribute "deprecate"  [attr-defined]
- apprise/URLBase.pyi:1: error: Module "logging" has no attribute "logger"; maybe "Logger"?
+ apprise/URLBase.pyi:1: error: Module "logging" has no attribute "logger"; maybe "Logger"?  [attr-defined]
- apprise/conversion.py:109: error: Need type annotation for "BLOCK_END" (hint: "BLOCK_END: Dict[<type>, <type>] = ...")
+ apprise/conversion.py:109: error: Need type annotation for "BLOCK_END" (hint: "BLOCK_END: Dict[<type>, <type>] = ...")  [var-annotated]
- apprise/AppriseLocale.py:57: error: Cannot find implementation or library stub for module named "__builtin__"
+ apprise/AppriseLocale.py:57: error: Cannot find implementation or library stub for module named "__builtin__"  [import]
- apprise/config/__init__.py:32: error: Module "apprise.common" has no attribute "CONFIG_SCHEMA_MAP"
+ apprise/config/__init__.py:32: error: Module "apprise.common" has no attribute "CONFIG_SCHEMA_MAP"  [attr-defined]
- apprise/attachment/__init__.py:32: error: Module "apprise.common" has no attribute "ATTACHMENT_SCHEMA_MAP"
+ apprise/attachment/__init__.py:32: error: Module "apprise.common" has no attribute "ATTACHMENT_SCHEMA_MAP"  [attr-defined]
- apprise/plugins/NotifyXML.py:32: error: Module "apprise.URLBase" has no attribute "PrivacyMode"
+ apprise/plugins/NotifyXML.py:32: error: Module "apprise.URLBase" has no attribute "PrivacyMode"  [attr-defined]
- apprise/plugins/NotifyXML.py:33: error: Module "apprise.common" has no attribute "NotifyImageSize"
+ apprise/plugins/NotifyXML.py:33: error: Module "apprise.common" has no attribute "NotifyImageSize"  [attr-defined]
- apprise/plugins/NotifyXML.py:90: error: "Type[NotifyBase]" has no attribute "template_tokens"
+ apprise/plugins/NotifyXML.py:90: error: "Type[NotifyBase]" has no attribute "template_tokens"  [attr-defined]
- apprise/plugins/NotifyXML.py:115: error: "Type[NotifyBase]" has no attribute "template_args"
+ apprise/plugins/NotifyXML.py:115: error: "Type[NotifyBase]" has no attribute "template_args"  [attr-defined]
- apprise/plugins/NotifyJSON.py:32: error: Module "apprise.URLBase" has no attribute "PrivacyMode"
+ apprise/plugins/NotifyJSON.py:32: error: Module "apprise.URLBase" has no attribute "PrivacyMode"  [attr-defined]
- apprise/plugins/NotifyJSON.py:33: error: Module "apprise.common" has no attribute "NotifyImageSize"
+ apprise/plugins/NotifyJSON.py:33: error: Module "apprise.common" has no attribute "NotifyImageSize"  [attr-defined]
- apprise/plugins/NotifyJSON.py:85: error: "Type[NotifyBase]" has no attribute "template_tokens"
+ apprise/plugins/NotifyJSON.py:85: error: "Type[NotifyBase]" has no attribute "template_tokens"  [attr-defined]
- apprise/plugins/NotifyJSON.py:110: error: "Type[NotifyBase]" has no attribute "template_args"
+ apprise/plugins/NotifyJSON.py:110: error: "Type[NotifyBase]" has no attribute "template_args"  [attr-defined]
- apprise/plugins/NotifyForm.py:30: error: Module "apprise.URLBase" has no attribute "PrivacyMode"
+ apprise/plugins/NotifyForm.py:30: error: Module "apprise.URLBase" has no attribute "PrivacyMode"  [attr-defined]
- apprise/plugins/NotifyForm.py:31: error: Module "apprise.common" has no attribute "NotifyImageSize"
+ apprise/plugins/NotifyForm.py:31: error: Module "apprise.common" has no attribute "NotifyImageSize"  [attr-defined]
- apprise/plugins/NotifyForm.py:83: error: "Type[NotifyBase]" has no attribute "template_tokens"
+ apprise/plugins/NotifyForm.py:83: error: "Type[NotifyBase]" has no attribute "template_tokens"  [attr-defined]
- apprise/plugins/NotifyForm.py:108: error: "Type[NotifyBase]" has no attribute "template_args"
+ apprise/plugins/NotifyForm.py:108: error: "Type[NotifyBase]" has no attribute "template_args"  [attr-defined]
- apprise/plugins/NotifyEnigma2.py:39: error: Module "apprise.URLBase" has no attribute "PrivacyMode"
+ apprise/plugins/NotifyEnigma2.py:39: error: Module "apprise.URLBase" has no attribute "PrivacyMode"  [attr-defined]
- apprise/plugins/NotifyEnigma2.py:106: error: "Type[NotifyBase]" has no attribute "template_tokens"
+ apprise/plugins/NotifyEnigma2.py:106: error: "Type[NotifyBase]" has no attribute "template_tokens"  [attr-defined]
- apprise/plugins/NotifyEnigma2.py:133: error: "Type[NotifyBase]" has no attribute "template_args"
+ apprise/plugins/NotifyEnigma2.py:133: error: "Type[NotifyBase]" has no attribute "template_args"  [attr-defined]
- apprise/plugins/NotifyFCM/oauth.py:48: error: Module "urllib" has no attribute "urlencode"
+ apprise/plugins/NotifyFCM/oauth.py:48: error: Module "urllib" has no attribute "urlencode"  [attr-defined]
- apprise/plugins/NotifyFCM/oauth.py:60: error: Cannot assign to a type
+ apprise/plugins/NotifyFCM/oauth.py:60: error: Cannot assign to a type  [misc]
- apprise/plugins/NotifyFCM/oauth.py:60: error: Incompatible types in assignment (expression has type "Type[ValueError]", variable has type "Type[JSONDecodeError]")
+ apprise/plugins/NotifyFCM/oauth.py:60: error: Incompatible types in assignment (expression has type "Type[ValueError]", variable has type "Type[JSONDecodeError]")  [assignment]
- apprise/utils.py:41: error: Module "urllib" has no attribute "unquote"
+ apprise/utils.py:41: error: Module "urllib" has no attribute "unquote"  [attr-defined]
- apprise/utils.py:42: error: Module "urllib" has no attribute "quote"
+ apprise/utils.py:42: error: Module "urllib" has no attribute "quote"  [attr-defined]
- apprise/utils.py:43: error: Cannot find implementation or library stub for module named "urlparse"
+ apprise/utils.py:43: error: Cannot find implementation or library stub for module named "urlparse"  [import]
- apprise/utils.py:44: error: Module "urllib" has no attribute "urlencode"
+ apprise/utils.py:44: error: Module "urllib" has no attribute "urlencode"  [attr-defined]
- apprise/config/ConfigBase.pyi:3: error: Module "apprise.URLBase" is not valid as a type
+ apprise/config/ConfigBase.pyi:3: error: Module "apprise.URLBase" is not valid as a type  [valid-type]
- apprise/config/ConfigBase.pyi:3: error: Invalid base class "URLBase"
+ apprise/config/ConfigBase.pyi:3: error: Invalid base class "URLBase"  [misc]
- apprise/decorators/CustomNotifyPlugin.py:57: error: Need type annotation for "_default_args" (hint: "_default_args: Dict[<type>, <type>] = ...")
+ apprise/decorators/CustomNotifyPlugin.py:57: error: Need type annotation for "_default_args" (hint: "_default_args: Dict[<type>, <type>] = ...")  [var-annotated]
- apprise/AppriseConfig.pyi:3: error: Name "AppriseAsset" already defined (by an import)
+ apprise/AppriseConfig.pyi:3: error: Name "AppriseAsset" already defined (by an import)  [no-redef]
- apprise/AppriseConfig.pyi:6: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:6: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:12: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/AppriseConfig.pyi:12: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:21: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/AppriseConfig.pyi:21: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:29: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/AppriseConfig.pyi:29: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:35: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:35: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:36: error: Self argument missing for a non-static method (or an invalid type for self)
+ apprise/AppriseConfig.pyi:36: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
- apprise/AppriseConfig.pyi:38: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/AppriseConfig.pyi:38: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:43: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:43: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:44: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:44: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:45: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:45: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseConfig.pyi:48: error: Module "apprise.config.ConfigBase" is not valid as a type
+ apprise/AppriseConfig.pyi:48: error: Module "apprise.config.ConfigBase" is not valid as a type  [valid-type]
- apprise/AppriseAttachment.pyi:3: error: Name "AppriseAsset" already defined (by an import)
+ apprise/AppriseAttachment.pyi:3: error: Name "AppriseAsset" already defined (by an import)  [no-redef]
- apprise/AppriseAttachment.pyi:6: error: Module "apprise.attachment.AttachBase" is not valid as a type
+ apprise/AppriseAttachment.pyi:6: error: Module "apprise.attachment.AttachBase" is not valid as a type  [valid-type]
- apprise/AppriseAttachment.pyi:27: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/AppriseAttachment.pyi:27: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/AppriseAttachment.pyi:30: error: Name "NotifyBase" is not defined
+ apprise/AppriseAttachment.pyi:30: error: Name "NotifyBase" is not defined  [name-defined]
- apprise/AppriseAttachment.pyi:33: error: Module "apprise.attachment.AttachBase" is not valid as a type
+ apprise/AppriseAttachment.pyi:33: error: Module "apprise.attachment.AttachBase" is not valid as a type  [valid-type]
- apprise/AppriseAttachment.pyi:34: error: Module "apprise.attachment.AttachBase" is not valid as a type
+ apprise/AppriseAttachment.pyi:34: error: Module "apprise.attachment.AttachBase" is not valid as a type  [valid-type]
- apprise/AppriseAttachment.pyi:37: error: Name "Iterator" is not defined
+ apprise/AppriseAttachment.pyi:37: error: Name "Iterator" is not defined  [name-defined]
- apprise/Apprise.pyi:3: error: Name "AppriseAsset" already defined (by an import)
+ apprise/Apprise.pyi:3: error: Name "AppriseAsset" already defined (by an import)  [no-redef]
- apprise/Apprise.pyi:3: error: Name "AppriseAttachment" already defined (by an import)
+ apprise/Apprise.pyi:3: error: Name "AppriseAttachment" already defined (by an import)  [no-redef]
- apprise/Apprise.pyi:3: error: Name "AppriseConfig" already defined (by an import)
+ apprise/Apprise.pyi:3: error: Name "AppriseConfig" already defined (by an import)  [no-redef]
- apprise/Apprise.pyi:7: error: Name "Union" is not defined
+ apprise/Apprise.pyi:7: error: Name "Union" is not defined  [name-defined]
- apprise/Apprise.pyi:8: error: Name "Union" is not defined
+ apprise/Apprise.pyi:8: error: Name "Union" is not defined  [name-defined]
- apprise/Apprise.pyi:8: error: Variable "apprise.Apprise._Server" is not valid as a type
+ apprise/Apprise.pyi:8: error: Variable "apprise.Apprise._Server" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:11: error: Name "Union" is not defined
+ apprise/Apprise.pyi:11: error: Name "Union" is not defined  [name-defined]
- apprise/Apprise.pyi:16: error: Variable "apprise.Apprise._Servers" is not valid as a type
+ apprise/Apprise.pyi:16: error: Variable "apprise.Apprise._Servers" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:17: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/Apprise.pyi:17: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:23: error: Name "Union" is not defined
+ apprise/Apprise.pyi:23: error: Name "Union" is not defined  [name-defined]
- apprise/Apprise.pyi:24: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/Apprise.pyi:24: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:25: error: Variable "apprise.Apprise._Tag" is not valid as a type
+ apprise/Apprise.pyi:25: error: Variable "apprise.Apprise._Tag" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:30: error: Variable "apprise.Apprise._Servers" is not valid as a type
+ apprise/Apprise.pyi:30: error: Variable "apprise.Apprise._Servers" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:31: error: Module "apprise.AppriseAsset" is not valid as a type
+ apprise/Apprise.pyi:31: error: Module "apprise.AppriseAsset" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:32: error: Variable "apprise.Apprise._Tag" is not valid as a type
+ apprise/Apprise.pyi:32: error: Variable "apprise.Apprise._Tag" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:42: error: Variable "apprise.Apprise._Tag" is not valid as a type
+ apprise/Apprise.pyi:42: error: Variable "apprise.Apprise._Tag" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:43: error: Module "apprise.AppriseAttachment" is not valid as a type
+ apprise/Apprise.pyi:43: error: Module "apprise.AppriseAttachment" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:52: error: Variable "apprise.Apprise._Tag" is not valid as a type
+ apprise/Apprise.pyi:52: error: Variable "apprise.Apprise._Tag" is not valid as a type  [valid-type]
- apprise/Apprise.pyi:53: error: Module "apprise.AppriseAttachment"

... (truncated 10751 lines) ...

cdce8p

I don't really like --hide-error-codes new config value. I would prefer to keep just --show-error-code with new default, that can be used as --show-error-code=False to fallback to the old way. Current configuration leaves too much space for potential errors: what if I have both? What if I have --show-error-code=False or --hide-error-code=True?

That's what I've done here 😄
--hide-error-code is an invertible_flag, the inverse being --show-error-code. To adjust the default, I needed the change from show to hide. You can still use --show-error-code=False.

This will require to pay extra attention to error codes from mypy team (which is a good thing). Since this change we would need to consider error code changes as breaking changes (probably) 🤔

I agree, better error codes are a good thing. Not sure though I would consider changing the error code a breaking change. E.g. we (did) have a lot of misc errors. We should be able to choose new / better once if suitable.

Updating the code for a new mypy release would still be easy enough. At worst, the type: ignore[...] error codes would need to be updated. I suspect that most still use bare type: ignores though, since we haven't enabled ignore-without-code by default.

cdce8p · 2022-09-27T12:14:58Z

mypyc/errors.py

        self.num_errors = 0
        self.num_warnings = 0
-        self._errors = mypy.errors.Errors()
+        self._errors = mypy.errors.Errors(hide_error_codes=True)


The PR would have enabled error codes for mypyc as well which resulted in a lot of failing tests. I'm not sure if we should do that too. The main focus was to enable it for mypy runs which is why I added hide_error_codes=True here.

cdce8p · 2022-09-27T12:15:33Z

test-data/unit/check-errorcodes.test

+
+[file mypy.ini]
+\[mypy]
+show_error_codes = True


I've already added one in check-flags.test right at the end.

python/mypy#13542

Mypy now shows error codes by default. It's unclear when this changed. It doesn't seem to be mentioned in the changelog, and both the original `show_error_codes` setting and the deprecation seem to be undocumented. This commit will remove `show_error_codes`/`--show-error-codes`. The inverse `hide_error_codes`/`--hide-error-codes` is still supported. https://github.com/python/mypy/blob/master/CHANGELOG.md python/mypy#13542 python/mypy#17083 https://mypy.readthedocs.io/en/stable/error_codes.html SchemaStore/schemastore#3422 SchemaStore/schemastore#3467 SchemaStore/schemastore#3472 https://www.schemastore.org/partial-mypy.json

Show error codes by default

b6e4397

This comment has been minimized.

Sign in to view

cdce8p marked this pull request as draft August 28, 2022 13:24

hauntsaninja mentioned this pull request Aug 28, 2022

Add option for strict-error-codes #13541

Closed

cdce8p added 3 commits August 29, 2022 11:33

Invert flag name

853e7c2

Update documentation

65ab26c

Remove default option from self_check.ini

f445ca8

This comment has been minimized.

Sign in to view

Fix tests and primer output

279dc1f

hauntsaninja reviewed Aug 29, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Fix additional test cases

bc423e9

This comment has been minimized.

Sign in to view

Fix 3

4fb94da

This comment has been minimized.

Sign in to view

Small improvements + new test cases

f0446bb

This comment has been minimized.

Sign in to view

One more test case

1690b75

cdce8p marked this pull request as ready for review August 30, 2022 15:00

cdce8p requested a review from hauntsaninja August 30, 2022 15:01

This comment has been minimized.

Sign in to view

hauntsaninja added the upnext label Sep 8, 2022

hauntsaninja approved these changes Sep 8, 2022

View reviewed changes

hauntsaninja mentioned this pull request Sep 27, 2022

Release 1.0 planning #13685

Closed

17 tasks

sobolevn reviewed Sep 27, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/master' into show-error-codes

bd98356

This comment has been minimized.

Sign in to view

Code review

c078de6

cdce8p commented Sep 27, 2022

View reviewed changes

hauntsaninja merged commit da43c91 into python:master Sep 27, 2022

cdce8p deleted the show-error-codes branch September 27, 2022 18:51

johnthagen mentioned this pull request Nov 16, 2022

Remove mypy show-error-codes configuration which will become default johnthagen/python-blueprint#137

Closed

bersbersbers mentioned this pull request Dec 21, 2023

feat: add mypy schema SchemaStore/schemastore#3422

Merged

DimitriPapadopoulos mentioned this pull request Dec 31, 2023

Update MyPy option name sphinx-doc/sphinx#11829

Closed

chrisjsewell mentioned this pull request Mar 18, 2024

✨ Add show_warning_types configuration variable sphinx-doc/sphinx#12131

Merged

MridulS added a commit to scipp/copier_template that referenced this pull request Apr 19, 2024

show_error_codes is true by default with mypy

aedc742

python/mypy#13542

MridulS mentioned this pull request Apr 19, 2024

show_error_codes is true by default with mypy scipp/copier_template#160

Merged

chrisjsewell mentioned this pull request Jul 16, 2024

Turn show_warning_types on by default sphinx-doc/sphinx#12597

Merged

sureshjoshi mentioned this pull request Feb 21, 2025

Fixed rule decorator factory typing to help call-by-name call sites pantsbuild/pants#21987

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Show error codes by default #13542

Show error codes by default #13542

Uh oh!

cdce8p commented Aug 28, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

hauntsaninja left a comment •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sobolevn left a comment

Uh oh!

Uh oh!

sobolevn Sep 27, 2022

Uh oh!

cdce8p Sep 27, 2022

Uh oh!

sobolevn Sep 27, 2022

Uh oh!

cdce8p Sep 27, 2022

Uh oh!

This comment has been minimized.

github-actions bot commented Sep 27, 2022

Uh oh!

cdce8p left a comment

Uh oh!

cdce8p Sep 27, 2022

Uh oh!

cdce8p Sep 27, 2022

Uh oh!

Uh oh!

Uh oh!

Show error codes by default #13542

Show error codes by default #13542

Uh oh!

Conversation

cdce8p commented Aug 28, 2022

Description

Uh oh!

This comment has been minimized.

This comment has been minimized.

hauntsaninja left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sobolevn Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

sobolevn Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

github-actions bot commented Sep 27, 2022

Uh oh!

cdce8p left a comment

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hauntsaninja left a comment •

edited

Loading