Skip to content

Fix Mypyc not compiling on Arch Linux #13978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix Mypyc not compiling on Arch Linux #13978

merged 2 commits into from
Nov 3, 2022

Conversation

dosisod
Copy link
Contributor

@dosisod dosisod commented Nov 1, 2022

Closes mypyc/mypyc#956

This was originally a part of #13953, see #13953 (comment)

JukkaL
JukkaL reviewed Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring C preprocessor warnings is not ideal, but I can't think of an easy alternative. It's important to support -O0 builds.

I guess we could use -D_FORTIFY_SOURCE=0 or something, but that would disable the checks always, which seems worse.

JukkaL
JukkaL approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit bc78eb5 into python:master Nov 3, 2022
@dosisod dosisod deleted the fix-mypyc-arch-linux branch November 4, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot test/install mypyc on Arch Linux
2 participants
@dosisod @JukkaL