Fix false negatives involving Unions and generators or coroutines #14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Nov 30, 2022
| @@ -925,3 +925,21 @@ async def f() -> AsyncGenerator[int, None]: | |||
|
|
|||
| [builtins fixtures/async_await.pyi] | |||
| [typing fixtures/typing-async.pyi] | |||
|
|
|||
| [case testAwaitUnion] | |||
There was a problem hiding this comment.
Does this also fix type checking yield in generators? If yes, can you add a test case for this?
There was a problem hiding this comment.
Yeah it does, will do!
hauntsaninja
changed the title
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/dependencies/owners.py:173: error: Returning Any from function declared to return "bool" [no-any-return]
- tanjun/dependencies/owners.py:183: error: Returning Any from function declared to return "bool" [no-any-return]
- tanjun/clients.py:2313: error: Returning Any from function declared to return "Snowflake" [no-any-return]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/formats/format.py:1233: error: Incompatible types in "yield" (actual type "Union[str, WriteBuffer[str], StringIO]", expected type "Union[WriteBuffer[str], StringIO]") [misc]
steam.py (https://github.com/Gobot1234/steam.py)
+ steam/state.py:1076: error: Incompatible types in assignment (expression has type "Union[GroupMember, None, ClanMember]", variable has type "Union[GroupMember, ClanMember]") [assignment]
+ steam/ext/commands/bot.py:616: error: No return value expected [return-value]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14223