Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --local-partial-types note to dmypy docs #15259

Merged
merged 2 commits into from May 18, 2023
Merged

Add --local-partial-types note to dmypy docs #15259

merged 2 commits into from May 18, 2023

Conversation

alanhdu
Copy link
Contributor

@alanhdu alanhdu commented May 17, 2023

Fixes #15214 but adding a note to the dmypy docs.

hauntsaninja
hauntsaninja reviewed May 17, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Would you mind moving it to the Basic Usage section, near the note about following imports (not sure how valid that following imports note is anymore, but that's a different matter)

hauntsaninja
hauntsaninja approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit d9d893f into python:master May 18, 2023
2 checks passed
@alanhdu alanhdu deleted the alan/dmypy-note branch May 18, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy and dmypy run are not agreeing
2 participants
@alanhdu @hauntsaninja