Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix abstract and non-abstract variant error for prop.deleter #15395

Merged
merged 1 commit into from Jun 8, 2023
Merged

Fix abstract and non-abstract variant error for prop.deleter #15395

merged 1 commit into from Jun 8, 2023

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Jun 8, 2023 •
edited

Fixes #4165. The this should probably error bit is #13649

@hauntsaninja hauntsaninja mentioned this pull request Jun 8, 2023
Open
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 4baf672 into python:master Jun 8, 2023
20 checks passed
@hauntsaninja hauntsaninja deleted the prop-delet branch June 8, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract Properties & Overloaded method has both abstract and non-abstract variants
2 participants
@hauntsaninja @ilevkivskyi