Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Optimize TYPE_CHECKING to False at Runtime #16263

Merged
merged 3 commits into from
Feb 28, 2024
Merged

[mypyc] Optimize TYPE_CHECKING to False at Runtime #16263

merged 3 commits into from
Feb 28, 2024

Conversation

srilman
Copy link
Contributor

@srilman srilman commented Oct 14, 2023

Fixes mypyc/mypyc#902

This PR finds references of typing.TYPE_CHECKING or typing_extensions.TYPE_CHECKING and optimizes them to False in mypyc.

@srilman
Copy link
Contributor Author

srilman commented Oct 28, 2023

@JukkaL Is there a way I can request a review?

@srilman
Copy link
Contributor Author

srilman commented Feb 6, 2024

@JukkaL ?

JukkaL
JukkaL approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR, and sorry about the slow review.

@JukkaL JukkaL merged commit 5a8cd80 into python:master Feb 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize away references to TYPE_CHECKING
2 participants
@srilman @JukkaL