Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path for checking self types #16352

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Add fast path for checking self types #16352

merged 1 commit into from
Oct 28, 2023

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Oct 28, 2023

The check was pretty expensive, though usually it's not doing anything non-trivial. Added a fast path for cases where we use the implicit self type, which covers the vast majority of cases.

This makes self-check about 4% faster.

The check was pretty expensive, though usually it's not doing
anything non-trivial. Added a fast path for cases where we use the
implicit self type, which covers the vast majority of cases.

This makes self-check about 4% faster.
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JukkaL JukkaL merged commit c76132f into master Oct 28, 2023
18 checks passed
@JukkaL JukkaL deleted the fast-self-type branch October 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants