Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict-optional in extending generic TypedDict #16398

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #16395

Copy link
Contributor

github-actions bot commented Nov 2, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JelleZijlstra JelleZijlstra merged commit 44e527a into python:master Nov 2, 2023
18 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-gen-opt-td branch November 2, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inheriting from a generic TypedDict with a T | None key inexplicably narrows the that key type to T
2 participants