Remove unnecessary mypyc files from wheel - #18416
Merged
Merged
Conversation
Collaborator
Author
|
/CC @mr-c |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
I can confirm this, thanks! |
JukkaL
approved these changes
Jan 10, 2025
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
This makes sense -- now mypy and mypyc are treated more consistently.
Merged
Collaborator
Author
|
This change uncovered a bug in the mypyc test suite which causes the wheel tests to fail. Fix #18444 |
ilevkivskyi
pushed a commit
that referenced
this pull request
Jan 11, 2025
#18416 removed the `mypyc/test-data` package from the wheel. This caused the wheel tests to fail. Use the `test_data_prefix` instead which uses the existing `MYPY_TEST_PREFIX` to determine the correct file location. https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/12712285989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove mypyc docs and some testing files from wheels. They aren't included for mypy itself as well. The sdist content will stay the same, so it's possible for distributors to continue to run the tests.
Files which will no longer be included