Skip to content

handle arg=None in stubgenc#18768

Merged
hauntsaninja merged 1 commit into
python:masterfrom
asottile:none-default-stubgenc
Mar 8, 2025
Merged

handle arg=None in stubgenc#18768
hauntsaninja merged 1 commit into
python:masterfrom
asottile:none-default-stubgenc

Conversation

@asottile

@asottile asottile commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

resolves #18757

@asottile asottile force-pushed the none-default-stubgenc branch from 7b8fe9f to 3477deb Compare March 7, 2025 20:04
@asottile asottile force-pushed the none-default-stubgenc branch from 3477deb to d61c049 Compare March 7, 2025 20:08

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with stubgenc, but this was clearly wrong, thank you!

@hauntsaninja hauntsaninja merged commit f339f2c into python:master Mar 8, 2025
@asottile asottile deleted the none-default-stubgenc branch March 8, 2025 02:38
@asottile

asottile commented Mar 8, 2025

Copy link
Copy Markdown
Contributor Author

Not familiar with stubgenc, but this was clearly wrong, thank you!

heh neither was I! but I took this chance to learn a bit more about it :) thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stubgen incorrectly represents function arguments whose default is None as having no default

2 participants