Skip to content

[mypyc] Add basic optimization for sorted #18902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[mypyc] Add basic optimization for sorted #18902

merged 1 commit into from
Apr 9, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Apr 8, 2025 •
edited
Loading

@cdce8p cdce8p added the topic-mypyc mypyc bugs label Apr 8, 2025
@cdce8p cdce8p requested a review from JukkaL April 8, 2025 16:05
JukkaL
JukkaL approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I measured a ~2x speedup in a microbenchmark that uses sorted(a) heavily.

@JukkaL JukkaL merged commit a4e79ea into python:master Apr 9, 2025
13 checks passed
@cdce8p cdce8p deleted the mypyc-sorted branch April 9, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
topic-mypyc mypyc bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @JukkaL