[docs] Update common_issues.rst: mention orjson in the Mypy slow section #19058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly just copies the verbiage from the release blog post.
for more information, see https://pre-commit.ci
sterliakov
reviewed
May 9, 2025
| @@ -218,6 +218,14 @@ daemon <mypy_daemon>`, which can speed up incremental mypy runtimes by | |||
| a factor of 10 or more. :ref:`Remote caching <remote-cache>` can | |||
| make cold mypy runs several times faster. | |||
|
|
|||
| Furthermore: as of `mypy 1.13 <https://mypy-lang.blogspot.com/2024/10/mypy-113-released.html>`_, | |||
There was a problem hiding this comment.
This is all history, are you sure that the changelog link and the specific version reference are relevant here?
There was a problem hiding this comment.
My instinct is, we might as well include it for people locked into Mypy version X who Google "Mypy slow" to see what they get. It can always be removed from the Mypy documentation later.
There was a problem hiding this comment.
They'll try pip install mypy[fast-cache], get a helpful message that such extra does not exist and, hopefully, figure out that using a version more than a year old has some drawbacks... But this is more a nitpick, I agree documentation should mention this extra and have no other objections:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just copies the verbiage from the release blog post.