Skip to content

Make stubtest ignore __slotnames__ - #19077

Merged
sobolevn merged 1 commit into
python:masterfrom
ngnpope:stubtest-slotnames
May 12, 2025
Merged

Make stubtest ignore __slotnames__#19077
sobolevn merged 1 commit into
python:masterfrom
ngnpope:stubtest-slotnames

Conversation

@ngnpope

@ngnpope ngnpope commented May 12, 2025

Copy link
Copy Markdown
Contributor

This is a cached list of names of slots added by the copyreg module.

See typeddjango/django-stubs#2584 for a case of these cropping up in django-stubs.

This is a cached list of names of slots added by the `copyreg` module.

See typeddjango/django-stubs#2584 for a case of
these cropping up in `django-stubs`.
@ngnpope

ngnpope commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

Ping @sobolevn 👋🏻

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of stubtest ignores for this! 👍

I will keep this open for a week or so, for others to comment. Ping me in a week to merge this, please, if there are no other opinions :)

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, seems like this is called from the language core, just implemented in copyreg.

@sobolevn
sobolevn merged commit addcff2 into python:master May 12, 2025
@ngnpope
ngnpope deleted the stubtest-slotnames branch May 12, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants