Skip to content

Don't consider indirect dependencies when calculating SCCs #19903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Don't consider indirect dependencies when calculating SCCs #19903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3488,7 +3488,7 @@ def process_stale_scc(graph: Graph, scc: list[str], manager: BuildManager) -> No


def sorted_components(
graph: Graph, vertices: AbstractSet[str] | None = None, pri_max: int = PRI_ALL
graph: Graph, vertices: AbstractSet[str] | None = None, pri_max: int = PRI_INDIRECT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name pri_max is a bit confusing -- dependencies with a priority less than this are considered. I don't want to change this logic at this point, since it would require larger changes as this function is used in a few different places.

) -> list[AbstractSet[str]]:
"""Return the graph's SCCs, topologically sorted by dependencies.

Expand Down
Loading