[mypyc] feat: support non-sequence inputs with known len in sequence_from_generator_preallocate_helper
#19935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is pretty simple, I just extended get_expr_length to work for a few more obvious cases: - `builtins.enumerate` - `builtins.map` - `builtins.zip` - `builtins.range` This PR is ready for review. Are you going to want tests for all of these? I don't want to spend time now until I know for sure.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…_from_generator_preallocate_helper`
BobTheBuidler
changed the title
sequence_from_generator_preallocate_helper
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequence_from_generator_preallocate_helper currently requires the genexp's sequence to be a Sequence type. Preallocating is quite nice, we should do it more often!
This PR extends it for cases where the sequence is not a Sequence type but the length is known at compile-time.
This PR was built on top of #19927 , as it doesn't make any sense to implement this optimization without that PR first merged. Separately, we cannot do any realiable IR testing on #19927 without this accompanying PR. You will notice slight differences in the IR test between the 2 branches, those differences indicate that the combination of the 2 PRs works as expected.