[mypyc] Fix broken cancellation handling in async def #19951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an unexpected undefined attribute error in a generator/async def.
The intent was to explicitly check if an attribute was undefined, but the
attribute read implicitly raised `AttributeError`, so the check was never
reached. Fixed by allowing error values to be read.
The error would looke like this (with no line number associated with it):
```
AttributeError("attribute '__mypyc_temp__12' of 'wait_Condition_gen' undefined")
```
p-sawicki
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an unexpected undefined attribute error in a generator/async def.
The intent was to explicitly check if an attribute was undefined, but the
attribute read implicitly raised
AttributeError, so the check was neverreached. Fixed by allowing error values to be read without raising
AttributeError.The error this fixes would look like this (with no line number associated with it):