Skip to content

Conversation

ilevkivskyi
Copy link
Member

This is to prepare for renaming native_internal -> librt.internal

Copy link
Contributor

github-actions bot commented Oct 6, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 9dc611f into python:master Oct 7, 2025
20 checks passed
@ilevkivskyi ilevkivskyi deleted the pin-librt branch October 7, 2025 00:56
@JukkaL
Copy link
Collaborator

JukkaL commented Oct 8, 2025

Before publishing mypy 1.19, I think we should accept any more recent versions of librt as well for mypy (use >= for version requirement), to not cause issues if a user uses an older mypy version but installs a more recent version of some third-party library that requires a more recent version of librt. Test requirements could probably continue to use the == check -- we'd just need to bump it whenever we release a new version of librt.

@ilevkivskyi
Copy link
Member Author

Yeah, I already unpinned it after completing the renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants