New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --include-private option to stubgen to include private members. #3367

Merged
merged 3 commits into from May 17, 2017

Conversation

Projects
None yet
2 participants
@chadrik
Contributor

chadrik commented May 15, 2017

I've found this option to be useful when generating stubs for some third party modules. It can also be useful when using stubs for internal use in place of comments annotations in python2. In this scenario, where stubs are used to type check their corresponding files, you can't omit members.

@ilevkivskyi

Thanks! Mostly looks good to me, just have few comments about test infrastructure.

Show outdated Hide outdated mypy/stubgen.py
Show outdated Hide outdated mypy/test/teststubgen.py
@ilevkivskyi

Thanks! Now this looks good to me.

@ilevkivskyi ilevkivskyi merged commit 2ca2eb4 into python:master May 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chadrik

This comment has been minimized.

Show comment
Hide comment
@chadrik

chadrik May 17, 2017

Contributor

Thanks!

Contributor

chadrik commented May 17, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment