New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct formatting for type objects #3374

Merged
merged 2 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@elazarg
Contributor

elazarg commented May 16, 2017

Fix #3050. (The discussion there is not over yet, but this PR can demonstrate the formatting)

@ilevkivskyi

Thanks! This mostly looks good to me, just one suggestion and one comment unrelated to this PR.

Show outdated Hide outdated test-data/unit/check-generics.test
Show outdated Hide outdated test-data/unit/pythoneval.test
Show outdated Hide outdated test-data/unit/check-functions.test
@ilevkivskyi

LGTM. If no one objects, then I will merge this soon.

@ilevkivskyi ilevkivskyi merged commit 3cd62e1 into python:master May 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum May 19, 2017

Member

Thank you! (Both.)

Member

gvanrossum commented May 19, 2017

Thank you! (Both.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment