Make binder handle unconditional ifs with no else #3567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes python#2673. The problem was that in the semantic analysis phase, we can only ever mark blocks as *unreachable*. So, if we have code of the form: ```python if typing.TYPE_CHECKING: assert isinstance(...) ``` ...nothing happens since there's no "else" block to mark as unreachable, which means the binder sees nothing special about this if statement and ignores the special conditional. I decided to just add a dummy empty "else" block if one doesn't already exist and mark it as unreachable. Two other solutions I considered were to add another field somewhere to record reachability or to repeat the special conditional checks in the typechecking phase, but these solutions seemed a bit redundant/wasteful.
|
Also, to clarify, this fix applies to any if statements involving OS platform checks, Python version checks, "are we using mypy" checks, and the like. I'm not sure if "unconditional ifs" is really the right phrase to use here, but naming things is hard... |
JukkaL
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2673.
The problem was that in the semantic analysis phase, we can only ever mark blocks as unreachable. So, if we have code of the form:
...nothing happens since there's no "else" block to mark as unreachable, which means the binder sees nothing special about this if statement and consequently ignores the special conditional.
I decided to just add a dummy empty "else" block if one doesn't already exist and mark it as unreachable. Two other solutions I considered were to add another field somewhere to record reachability or to repeat the special conditional checks in the typechecking phase, but these solutions seemed a bit redundant/wasteful.