New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any subtype of `typing.Mapping[str, Any]` to be passed in as kwargs. #3604

Merged
merged 4 commits into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@rowillia
Contributor

rowillia commented Jun 23, 2017

This fixes #3595

@gvanrossum gvanrossum requested a review from ilinum Jun 26, 2017

@ilevkivskyi

Looks good!

Just two small comments.

Show outdated Hide outdated mypy/messages.py
Show outdated Hide outdated test-data/unit/check-kwargs.test
@ilinum

Looks good overall!

Just a couple of small things.

Show outdated Hide outdated mypy/messages.py
Show outdated Hide outdated test-data/unit/fixtures/args.pyi
Show outdated Hide outdated mypy/messages.py
@ilinum

ilinum approved these changes Jun 27, 2017

LGTM!

Let's merge the PR when @ilevkivskyi approves it.

@ilevkivskyi

Thanks!

@ilevkivskyi ilevkivskyi merged commit a386107 into python:master Jun 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment