Allow instances of a class to access inner class definitions on that class. #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Jun 29, 2017
|
I too had similar concerns on further consideration, however, I cannot think of another case where an inner class might cause issues like this. Though I suppose not considering uses of inner classes is exactly what caused the bug. I think it would be better to fix semanal, as it would avoid potential future issues. Also I don't like the idea of mypy "lying" about the type, as it makes the code harder to understand unless you are familiar with this hack. |
gvanrossum
reviewed
Jun 30, 2017
test-data/unit/check-classes.test
Outdated
|
|
||
| reveal_type(Foo.Meta.name) # E: Revealed type is 'builtins.str' | ||
| reveal_type(Foo().meta.name) # E: Revealed type is 'builtins.str' | ||
| reveal_type(Foo().Meta.name) # E: Revealed type is 'builtins.str' |
There was a problem hiding this comment.
Why not test Foo.meta.name too?
And what will the types of Foo.Meta, Foo().Meta, Foo.meta and Foo().meta be revealed to be?
There was a problem hiding this comment.
Thanks for the feedback! Added those tests in.
This was referenced Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3635