New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on name collision for self attributes #3700

Merged
merged 3 commits into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Jul 12, 2017

Fixes #3687 (fixes both the crash and the underlying name resolution issue).

The fix is quite simple, I also noticed that normalized flag for symbol table nodes was not serialized, so I added this too.

Ivan Levkivskyi
@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Jul 12, 2017

Collaborator

I just realized that in my tests the relevant cache is not read, so that I added one more incremental test.

Collaborator

ilevkivskyi commented Jul 12, 2017

I just realized that in my tests the relevant cache is not read, so that I added one more incremental test.

@ethanhs

Looks good. Everything related to this that I threw at it worked.

@gvanrossum gvanrossum merged commit f127e2c into python:master Jul 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Jul 12, 2017

Member

Thanks for the fix, and thanks Ethan for the thorough testing!

Member

gvanrossum commented Jul 12, 2017

Thanks for the fix, and thanks Ethan for the thorough testing!

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fullname-crash branch Jul 18, 2017

@gvanrossum gvanrossum referenced this pull request Jul 18, 2017

Closed

Release mypy 0.521 #3732

gvanrossum added a commit that referenced this pull request Jul 18, 2017

Fix crash on name collision for self attributes (#3700)
Fixes #3687 (fixes both the crash and the underlying name resolution issue).

The fix is quite simple, I also noticed that normalized flag for symbol table nodes was not serialized, so I added this too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment