New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for incompatible default argument (take 2) #3783

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@elazarg
Contributor

elazarg commented Jul 31, 2017

Reopen #3773

Rephrase 'incompatible default' message
Add tests for tuple parameter
@elazarg

This comment has been minimized.

Show comment
Hide comment
@elazarg
Contributor

elazarg commented Jul 31, 2017

@gvanrossum

Please just fix the nit (remove no'), don't do anything else.

Show outdated Hide outdated mypy/checker.py

@gvanrossum gvanrossum merged commit 6366a02 into python:master Jul 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Jul 31, 2017

Member

Thanks! Next time it would be nice to have an issue before you start coding. :-)

Member

gvanrossum commented Jul 31, 2017

Thanks! Next time it would be nice to have an issue before you start coding. :-)

@elazarg

This comment has been minimized.

Show comment
Hide comment
@elazarg

elazarg Jul 31, 2017

Contributor

Will do.

Contributor

elazarg commented Jul 31, 2017

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment