New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate metadata if errors were previously ignored #3793

Merged
merged 2 commits into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@mhahnenberg
Contributor

mhahnenberg commented Aug 2, 2017

Using --incremental with --follow-imports=silent triggered a bug where a
file was not typechecked due to the presence of a metadata file
and accompanying AST from a previous run and would therefore not print any
errors. This diff fixes the issue by recording whether errors were
silenced in the metadata file when it was created and ignoring these files if
errors are no longer silenced.

Fixes #3639

Invalidate metadata if errors were previously ignored
Using --incremental with --follow-imports=silent triggered a bug where a
file was not typechecked due to the presence of a metadata file
and accompanying AST from a previous run and would therefore not print any
errors. This diff fixes the issue by recording whether errors were
silenced in the metadata file when it was created and ignoring these files if
errors are no longer silenced.
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Aug 18, 2017

Member

Sorry, it's vacation season and there are few people around to review this. We'll get to it.

Member

gvanrossum commented Aug 18, 2017

Sorry, it's vacation season and there are few people around to review this. We'll get to it.

@gvanrossum gvanrossum self-assigned this Aug 22, 2017

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Aug 22, 2017

Member

LG, waiting for the tests to pass after the resolve.

Member

gvanrossum commented Aug 22, 2017

LG, waiting for the tests to pass after the resolve.

@gvanrossum gvanrossum merged commit 64d5b96 into python:master Aug 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Aug 22, 2017

Member

Thanks! This addresses a nasty obscure corner case.

Member

gvanrossum commented Aug 22, 2017

Thanks! This addresses a nasty obscure corner case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment