New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --output-dir option to stubgen #3902

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@brianbruggeman
Contributor

brianbruggeman commented Aug 31, 2017

Currently, the output folder is hard-coded.

  • Adds an option (--output-dir) to the stubgen command-line interface
    -- allows user to provide a different output folder other than 'out'
    -- defaults to 'out'
    -- allows ~user and relative '.' paths

  • Now creates a new folder if it doesn't already exist

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Aug 31, 2017

Member

The default should really remain 'out'.

Member

gvanrossum commented Aug 31, 2017

The default should really remain 'out'.

@brianbruggeman

This comment has been minimized.

Show comment
Hide comment
@brianbruggeman

brianbruggeman Aug 31, 2017

Contributor

Is there a reason/backstory on why out is currently hard-coded?

Contributor

brianbruggeman commented Aug 31, 2017

Is there a reason/backstory on why out is currently hard-coded?

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Sep 1, 2017

Member

why out is currently hard-coded?

This makes it clear what the output is from the script and makes it easy to throw it away if you prefer to start over.

Member

gvanrossum commented Sep 1, 2017

why out is currently hard-coded?

This makes it clear what the output is from the script and makes it easy to throw it away if you prefer to start over.

Show outdated Hide outdated mypy/stubgen.py
Show outdated Hide outdated mypy/stubgen.py
Show outdated Hide outdated mypy/stubgen.py
Show outdated Hide outdated mypy/stubgen.py
Adds --output-dir option to stubgen
* Adds an option (--output-dir) to the stubgen command-line interface
  -- allows user to provide a different output folder other than 'out'
  -- defaults to out
  -- allows ~user and relative '.' paths
  -- Adds help documentation and updates --output-dir to -o

@gvanrossum gvanrossum merged commit 8b43e15 into python:master Sep 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Sep 20, 2017

Member

Thanks!

Member

gvanrossum commented Sep 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment