Adds --output-dir option to stubgen #3902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianbruggeman
force-pushed
the
add-output-dir-option-to-stubgen
branch
from
51441af to
3c76fa7
Compare
|
The default should really remain 'out'. |
|
Is there a reason/backstory on why |
brianbruggeman
force-pushed
the
add-output-dir-option-to-stubgen
branch
3 times, most recently
from
9a2a246 to
ca2576f
Compare
This makes it clear what the output is from the script and makes it easy to throw it away if you prefer to start over. |
gvanrossum
requested changes
Sep 19, 2017
mypy/stubgen.py
Outdated
| args = args[1:] | ||
| # Resolve/expand output_dir; use symlinks | ||
| if output_dir.startswith('~'): | ||
| output_dir = os.path.expanduser(output_dir) |
There was a problem hiding this comment.
Normally the shell takes care of this. I think on Windows it may not -- but is it really important enough to support?
mypy/stubgen.py
Outdated
| if output_dir.startswith('~'): | ||
| output_dir = os.path.expanduser(output_dir) | ||
| elif output_dir == '.': | ||
| output_dir = os.getenv('PWD') or os.getcwd() |
There was a problem hiding this comment.
What's the purpose of this? I don't believe stubgen ever changes the current directory.
There was a problem hiding this comment.
These are completely unnecessary.
mypy/stubgen.py
Outdated
| elif output_dir == '.': | ||
| output_dir = os.getenv('PWD') or os.getcwd() | ||
| else: | ||
| output_dir = os.path.abspath(output_dir) |
mypy/stubgen.py
Outdated
| @@ -697,6 +712,9 @@ def parse_options(args: List[str]) -> Options: | |||
| usage() | |||
| if not interpreter: | |||
| interpreter = sys.executable if pyversion[0] == 3 else default_python2_interpreter() | |||
| # Build the output folder if it doesn't already exist. | |||
* Adds an option (--output-dir) to the stubgen command-line interface -- allows user to provide a different output folder other than 'out' -- defaults to out -- allows ~user and relative '.' paths -- Adds help documentation and updates --output-dir to -o
brianbruggeman
force-pushed
the
add-output-dir-option-to-stubgen
branch
from
ca2576f to
99adac9
Compare
gvanrossum
approved these changes
Sep 20, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the output folder is hard-coded.
Adds an option (--output-dir) to the stubgen command-line interface
-- allows user to provide a different output folder other than 'out'
-- defaults to 'out'
-- allows ~user and relative '.' paths
Now creates a new folder if it doesn't already exist