New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format types nicely in incorrectly-returning-Any warning #3910

Merged
merged 3 commits into from Sep 2, 2017

Conversation

Projects
None yet
2 participants
@OddBloke
Contributor

OddBloke commented Sep 2, 2017

This fixes #3899.

@ilevkivskyi

Thanks! Just few suggestions.

Show outdated Hide outdated mypy/messages.py
Show outdated Hide outdated test-data/unit/check-warnings.test
@OddBloke

This comment has been minimized.

Show comment
Hide comment
@OddBloke

OddBloke Sep 2, 2017

Contributor

@ilevkivskyi Fixed.

Contributor

OddBloke commented Sep 2, 2017

@ilevkivskyi Fixed.

@OddBloke

This comment has been minimized.

Show comment
Hide comment
@OddBloke

OddBloke Sep 2, 2017

Contributor

(Thanks for the review!)

Contributor

OddBloke commented Sep 2, 2017

(Thanks for the review!)

@ilevkivskyi ilevkivskyi merged commit be5c456 into python:master Sep 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Sep 2, 2017

Collaborator

@OddBloke It looks like you are interested in the error messages, you might take a look at label "topic-usability", there are several issues related to error messages. For example you could start by looking at #963 that was previously attempted in #3433 by @quartox.

Collaborator

ilevkivskyi commented Sep 2, 2017

@OddBloke It looks like you are interested in the error messages, you might take a look at label "topic-usability", there are several issues related to error messages. For example you could start by looking at #963 that was previously attempted in #3433 by @quartox.

@OddBloke OddBloke deleted the OddBloke:bug/3899 branch Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment