New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using decorated function with multiple definitions #4064

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
2 participants
@elazarg
Contributor

elazarg commented Oct 5, 2017

Quick fix for #3574 - fall back to Any when there are multiple definitions of a decorated function, if the decorator is not typing.overload. This might not be the best solution, but it's better than crashing.

(This also does not address the deeper problem - the fact that OverloadedFuncDefs are not necessarily overloaded functions)

@ilevkivskyi

After some thinking, it looks like a reasonable fix. I will merge this soon if there are no objections.

@ilevkivskyi ilevkivskyi merged commit a8f494c into python:master Oct 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment